summaryrefslogtreecommitdiffstats
path: root/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-flags-indiv-modal/osd-flags-indiv-modal.component.spec.ts
blob: 93c9e9adcbbf0484aeed02dfb40905a5eb7bf6e1 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { RouterTestingModule } from '@angular/router/testing';

import { NgbActiveModal, NgbTooltipModule } from '@ng-bootstrap/ng-bootstrap';
import { ToastrModule } from 'ngx-toastr';
import { of as observableOf } from 'rxjs';

import { OsdService } from '~/app/shared/api/osd.service';
import { NotificationType } from '~/app/shared/enum/notification-type.enum';
import { Flag } from '~/app/shared/models/flag';
import { NotificationService } from '~/app/shared/services/notification.service';
import { SharedModule } from '~/app/shared/shared.module';
import { configureTestBed } from '~/testing/unit-test-helper';
import { OsdFlagsIndivModalComponent } from './osd-flags-indiv-modal.component';

describe('OsdFlagsIndivModalComponent', () => {
  let component: OsdFlagsIndivModalComponent;
  let fixture: ComponentFixture<OsdFlagsIndivModalComponent>;
  let httpTesting: HttpTestingController;
  let osdService: OsdService;

  configureTestBed({
    imports: [
      HttpClientTestingModule,
      ReactiveFormsModule,
      SharedModule,
      ToastrModule.forRoot(),
      NgbTooltipModule,
      RouterTestingModule
    ],
    declarations: [OsdFlagsIndivModalComponent],
    providers: [NgbActiveModal]
  });

  beforeEach(() => {
    httpTesting = TestBed.inject(HttpTestingController);
    fixture = TestBed.createComponent(OsdFlagsIndivModalComponent);
    component = fixture.componentInstance;
    osdService = TestBed.inject(OsdService);
  });

  it('should create', () => {
    expect(component).toBeTruthy();
  });

  describe('getActivatedIndivFlags', () => {
    function checkFlagsCount(
      counts: { [key: string]: number },
      expected: { [key: string]: number }
    ) {
      Object.entries(expected).forEach(([expectedKey, expectedValue]) => {
        expect(counts[expectedKey]).toBe(expectedValue);
      });
    }

    it('should count correctly if no flag has been set', () => {
      component.selected = generateSelected();
      const countedFlags = component.getActivatedIndivFlags();
      checkFlagsCount(countedFlags, { noup: 0, nodown: 0, noin: 0, noout: 0 });
    });

    it('should count correctly if some of the flags have been set', () => {
      component.selected = generateSelected([['noin'], ['noin', 'noout'], ['nodown']]);
      const countedFlags = component.getActivatedIndivFlags();
      checkFlagsCount(countedFlags, { noup: 0, nodown: 1, noin: 2, noout: 1 });
    });
  });

  describe('changeValue', () => {
    it('should change value correctly and set indeterminate to false', () => {
      const testFlag = component.flags[0];
      const value = testFlag.value;
      component.changeValue(testFlag);
      expect(testFlag.value).toBe(!value);
      expect(testFlag.indeterminate).toBeFalsy();
    });
  });

  describe('resetSelection', () => {
    it('should set a new flags object by deep cloning the initial selection', () => {
      component.resetSelection();
      expect(component.flags === component.initialSelection).toBeFalsy();
    });
  });

  describe('OSD single-select', () => {
    beforeEach(() => {
      component.selected = [{ osd: 0 }];
    });

    describe('ngOnInit', () => {
      it('should clone flags as initial selection', () => {
        expect(component.flags === component.initialSelection).toBeFalsy();
      });

      it('should initialize form correctly if no individual and global flags are set', () => {
        component.selected[0]['state'] = ['exists', 'up'];
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        checkFlags(component.flags);
      });

      it('should initialize form correctly if individual but no global flags are set', () => {
        component.selected[0]['state'] = ['exists', 'noout', 'up'];
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        const expected = {
          noout: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if multiple individual but no global flags are set', () => {
        component.selected[0]['state'] = ['exists', 'noin', 'noout', 'up'];
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        const expected = {
          noout: { value: true, clusterWide: false, indeterminate: false },
          noin: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if no individual but global flags are set', () => {
        component.selected[0]['state'] = ['exists', 'up'];
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf(['noout']));
        fixture.detectChanges();
        const expected = {
          noout: { value: false, clusterWide: true, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });
    });

    describe('submitAction', () => {
      let notificationType: NotificationType;
      let notificationService: NotificationService;
      let bsModalRef: NgbActiveModal;
      let flags: object;

      beforeEach(() => {
        notificationService = TestBed.inject(NotificationService);
        spyOn(notificationService, 'show').and.callFake((type) => {
          notificationType = type;
        });
        bsModalRef = TestBed.inject(NgbActiveModal);
        spyOn(bsModalRef, 'close').and.callThrough();
        flags = {
          nodown: false,
          noin: false,
          noout: false,
          noup: false
        };
      });

      it('should submit an activated flag', () => {
        const code = component.flags[0].code;
        component.flags[0].value = true;
        component.submitAction();
        flags[code] = true;

        const req = httpTesting.expectOne('api/osd/flags/individual');
        req.flush({ flags, ids: [0] });
        expect(req.request.body).toEqual({ flags, ids: [0] });
        expect(notificationType).toBe(NotificationType.success);
        expect(component.activeModal.close).toHaveBeenCalledTimes(1);
      });

      it('should submit multiple flags', () => {
        const codes = [component.flags[0].code, component.flags[1].code];
        component.flags[0].value = true;
        component.flags[1].value = true;
        component.submitAction();
        flags[codes[0]] = true;
        flags[codes[1]] = true;

        const req = httpTesting.expectOne('api/osd/flags/individual');
        req.flush({ flags, ids: [0] });
        expect(req.request.body).toEqual({ flags, ids: [0] });
        expect(notificationType).toBe(NotificationType.success);
        expect(component.activeModal.close).toHaveBeenCalledTimes(1);
      });

      it('should hide modal if request fails', () => {
        component.flags = [];
        component.submitAction();
        const req = httpTesting.expectOne('api/osd/flags/individual');
        req.flush([], { status: 500, statusText: 'failure' });
        expect(notificationService.show).toHaveBeenCalledTimes(0);
        expect(component.activeModal.close).toHaveBeenCalledTimes(1);
      });
    });
  });

  describe('OSD multi-select', () => {
    describe('ngOnInit', () => {
      it('should initialize form correctly if same individual and no global flags are set', () => {
        component.selected = generateSelected([['noin'], ['noin'], ['noin']]);
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        const expected = {
          noin: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if different individual and no global flags are set', () => {
        component.selected = generateSelected([['noin'], ['noout'], ['noin']]);
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        const expected = {
          noin: { value: false, clusterWide: false, indeterminate: true },
          noout: { value: false, clusterWide: false, indeterminate: true }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if different and same individual and no global flags are set', () => {
        component.selected = generateSelected([
          ['noin', 'nodown'],
          ['noout', 'nodown'],
          ['noin', 'nodown']
        ]);
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf([]));
        fixture.detectChanges();
        const expected = {
          noin: { value: false, clusterWide: false, indeterminate: true },
          noout: { value: false, clusterWide: false, indeterminate: true },
          nodown: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if a flag is set for all OSDs individually and globally', () => {
        component.selected = generateSelected([
          ['noin', 'nodown'],
          ['noout', 'nodown'],
          ['noin', 'nodown']
        ]);
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf(['noout']));
        fixture.detectChanges();
        const expected = {
          noin: { value: false, clusterWide: false, indeterminate: true },
          noout: { value: false, clusterWide: true, indeterminate: true },
          nodown: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });

      it('should initialize form correctly if different individual and global flags are set', () => {
        component.selected = generateSelected([
          ['noin', 'nodown', 'noout'],
          ['noout', 'nodown'],
          ['noin', 'nodown', 'noout']
        ]);
        spyOn(osdService, 'getFlags').and.callFake(() => observableOf(['noout']));
        fixture.detectChanges();
        const expected = {
          noin: { value: false, clusterWide: false, indeterminate: true },
          noout: { value: true, clusterWide: true, indeterminate: false },
          nodown: { value: true, clusterWide: false, indeterminate: false }
        };
        checkFlags(component.flags, expected);
      });
    });

    describe('submitAction', () => {
      let notificationType: NotificationType;
      let notificationService: NotificationService;
      let bsModalRef: NgbActiveModal;
      let flags: object;

      beforeEach(() => {
        notificationService = TestBed.inject(NotificationService);
        spyOn(notificationService, 'show').and.callFake((type) => {
          notificationType = type;
        });
        bsModalRef = TestBed.inject(NgbActiveModal);
        spyOn(bsModalRef, 'close').and.callThrough();
        flags = {
          nodown: false,
          noin: false,
          noout: false,
          noup: false
        };
      });

      it('should submit an activated flag for multiple OSDs', () => {
        component.selected = generateSelected();
        const code = component.flags[0].code;
        const submittedIds = [0, 1, 2];
        component.flags[0].value = true;
        component.submitAction();
        flags[code] = true;

        const req = httpTesting.expectOne('api/osd/flags/individual');
        req.flush({ flags, ids: submittedIds });
        expect(req.request.body).toEqual({ flags, ids: submittedIds });
        expect(notificationType).toBe(NotificationType.success);
        expect(component.activeModal.close).toHaveBeenCalledTimes(1);
      });

      it('should submit multiple flags for multiple OSDs', () => {
        component.selected = generateSelected();
        const codes = [component.flags[0].code, component.flags[1].code];
        const submittedIds = [0, 1, 2];
        component.flags[0].value = true;
        component.flags[1].value = true;
        component.submitAction();
        flags[codes[0]] = true;
        flags[codes[1]] = true;

        const req = httpTesting.expectOne('api/osd/flags/individual');
        req.flush({ flags, ids: submittedIds });
        expect(req.request.body).toEqual({ flags, ids: submittedIds });
        expect(notificationType).toBe(NotificationType.success);
        expect(component.activeModal.close).toHaveBeenCalledTimes(1);
      });
    });
  });

  function checkFlags(flags: Flag[], expected: object = {}) {
    flags.forEach((flag) => {
      let value = false;
      let clusterWide = false;
      let indeterminate = false;
      if (Object.keys(expected).includes(flag.code)) {
        value = expected[flag.code]['value'];
        clusterWide = expected[flag.code]['clusterWide'];
        indeterminate = expected[flag.code]['indeterminate'];
      }
      expect(flag.value).toBe(value);
      expect(flag.clusterWide).toBe(clusterWide);
      expect(flag.indeterminate).toBe(indeterminate);
    });
  }

  function generateSelected(flags: string[][] = []) {
    const defaultFlags = ['exists', 'up'];
    const osds = [];
    const count = flags.length || 3;
    for (let i = 0; i < count; i++) {
      const osd = {
        osd: i,
        state: defaultFlags.concat(flags[i]) || defaultFlags
      };
      osds.push(osd);
    }
    return osds;
  }
});