1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
|
import { FormControl } from '@angular/forms';
import _ from 'lodash';
import { configureTestBed, Mocks } from '~/testing/unit-test-helper';
import { CrushNode } from '../models/crush-node';
import { CrushNodeSelectionClass } from './crush.node.selection.class';
describe('CrushNodeSelectionService', () => {
const nodes = Mocks.getCrushMap();
let service: CrushNodeSelectionClass;
let controls: {
root: FormControl;
failure: FormControl;
device: FormControl;
};
// Object contains functions to get something
const get = {
nodeByName: (name: string): CrushNode => nodes.find((node) => node.name === name),
nodesByNames: (names: string[]): CrushNode[] => names.map(get.nodeByName)
};
// Expects that are used frequently
const assert = {
formFieldValues: (root: CrushNode, failureDomain: string, device: string) => {
expect(controls.root.value).toEqual(root);
expect(controls.failure.value).toBe(failureDomain);
expect(controls.device.value).toBe(device);
},
valuesOnRootChange: (
rootName: string,
expectedFailureDomain: string,
expectedDevice: string
) => {
const node = get.nodeByName(rootName);
controls.root.setValue(node);
assert.formFieldValues(node, expectedFailureDomain, expectedDevice);
},
failureDomainNodes: (
failureDomains: { [failureDomain: string]: CrushNode[] },
expected: { [failureDomains: string]: string[] | CrushNode[] }
) => {
expect(Object.keys(failureDomains)).toEqual(Object.keys(expected));
Object.keys(failureDomains).forEach((key) => {
if (_.isString(expected[key][0])) {
expect(failureDomains[key]).toEqual(get.nodesByNames(expected[key] as string[]));
} else {
expect(failureDomains[key]).toEqual(expected[key]);
}
});
}
};
configureTestBed({
providers: [CrushNodeSelectionClass]
});
beforeEach(() => {
controls = {
root: new FormControl(null),
failure: new FormControl(''),
device: new FormControl('')
};
// Normally this should be extended by the class using it
service = new CrushNodeSelectionClass();
// Therefore to get it working correctly use "this" instead of "service"
service.initCrushNodeSelection(nodes, controls.root, controls.failure, controls.device);
});
it('should be created', () => {
expect(service).toBeTruthy();
expect(nodes.length).toBe(12);
});
describe('lists', () => {
afterEach(() => {
// The available buckets should not change
expect(service.buckets).toEqual(
get.nodesByNames(['default', 'hdd-rack', 'mix-host', 'ssd-host', 'ssd-rack'])
);
});
it('has the following lists after init', () => {
assert.failureDomainNodes(service.failureDomains, {
host: ['ssd-host', 'mix-host'],
osd: ['osd.1', 'osd.0', 'osd.2'],
rack: ['hdd-rack', 'ssd-rack'],
'osd-rack': ['osd2.0', 'osd2.1', 'osd3.0', 'osd3.1']
});
expect(service.devices).toEqual(['hdd', 'ssd']);
});
it('has the following lists after selection of ssd-host', () => {
controls.root.setValue(get.nodeByName('ssd-host'));
assert.failureDomainNodes(service.failureDomains, {
// Not host as it only exist once
osd: ['osd.1', 'osd.0', 'osd.2']
});
expect(service.devices).toEqual(['ssd']);
});
it('has the following lists after selection of mix-host', () => {
controls.root.setValue(get.nodeByName('mix-host'));
expect(service.devices).toEqual(['hdd', 'ssd']);
assert.failureDomainNodes(service.failureDomains, {
rack: ['hdd-rack', 'ssd-rack'],
'osd-rack': ['osd2.0', 'osd2.1', 'osd3.0', 'osd3.1']
});
});
});
describe('selection', () => {
it('selects the first root after init automatically', () => {
assert.formFieldValues(get.nodeByName('default'), 'osd-rack', '');
});
it('should select all values automatically by selecting "ssd-host" as root', () => {
assert.valuesOnRootChange('ssd-host', 'osd', 'ssd');
});
it('selects automatically the most common failure domain', () => {
// Select mix-host as mix-host has multiple failure domains (osd-rack and rack)
assert.valuesOnRootChange('mix-host', 'osd-rack', '');
});
it('should override automatic selections', () => {
assert.formFieldValues(get.nodeByName('default'), 'osd-rack', '');
assert.valuesOnRootChange('ssd-host', 'osd', 'ssd');
assert.valuesOnRootChange('mix-host', 'osd-rack', '');
});
it('should not override manual selections if possible', () => {
controls.failure.setValue('rack');
controls.failure.markAsDirty();
controls.device.setValue('ssd');
controls.device.markAsDirty();
assert.valuesOnRootChange('mix-host', 'rack', 'ssd');
});
it('should preselect device by domain selection', () => {
controls.failure.setValue('osd');
assert.formFieldValues(get.nodeByName('default'), 'osd', 'ssd');
});
});
describe('get available OSDs count', () => {
it('should have 4 available OSDs with the default selection', () => {
expect(service.deviceCount).toBe(4);
});
it('should reduce available OSDs to 2 if a device type is set', () => {
controls.device.setValue('ssd');
controls.device.markAsDirty();
expect(service.deviceCount).toBe(2);
});
it('should show 3 OSDs when selecting "ssd-host"', () => {
assert.valuesOnRootChange('ssd-host', 'osd', 'ssd');
expect(service.deviceCount).toBe(3);
});
});
describe('search tree', () => {
it('returns the following list after searching for mix-host', () => {
const subNodes = CrushNodeSelectionClass.search(nodes, 'mix-host');
expect(subNodes).toEqual(
get.nodesByNames([
'mix-host',
'hdd-rack',
'osd2.0',
'osd2.1',
'ssd-rack',
'osd3.0',
'osd3.1'
])
);
});
it('returns the following list after searching for mix-host with SSDs', () => {
const subNodes = CrushNodeSelectionClass.search(nodes, 'mix-host~ssd');
expect(subNodes.map((n) => n.name)).toEqual(['mix-host', 'ssd-rack', 'osd3.0', 'osd3.1']);
});
it('returns an empty array if node can not be found', () => {
expect(CrushNodeSelectionClass.search(nodes, 'not-there')).toEqual([]);
});
it('returns the following list after searching for mix-host failure domains', () => {
const subNodes = CrushNodeSelectionClass.search(nodes, 'mix-host');
assert.failureDomainNodes(CrushNodeSelectionClass.getFailureDomains(subNodes), {
host: ['mix-host'],
rack: ['hdd-rack', 'ssd-rack'],
'osd-rack': ['osd2.0', 'osd2.1', 'osd3.0', 'osd3.1']
});
});
it('returns the following list after searching for mix-host failure domains for a specific type', () => {
const subNodes = CrushNodeSelectionClass.search(nodes, 'mix-host~hdd');
const hddHost = _.cloneDeep(get.nodesByNames(['mix-host'])[0]);
hddHost.children = [-4];
assert.failureDomainNodes(CrushNodeSelectionClass.getFailureDomains(subNodes), {
host: [hddHost],
rack: ['hdd-rack'],
'osd-rack': ['osd2.0', 'osd2.1']
});
const ssdHost = _.cloneDeep(get.nodesByNames(['mix-host'])[0]);
ssdHost.children = [-5];
assert.failureDomainNodes(
CrushNodeSelectionClass.searchFailureDomains(nodes, 'mix-host~ssd'),
{
host: [ssdHost],
rack: ['ssd-rack'],
'osd-rack': ['osd3.0', 'osd3.1']
}
);
});
});
});
|
