1 files changed, 162 insertions, 0 deletions
diff --git a/dom/webgpu/tests/cts/checkout/src/webgpu/api/validation/encoding/queries/begin_end.spec.ts b/dom/webgpu/tests/cts/checkout/src/webgpu/api/validation/encoding/queries/begin_end.spec.ts
new file mode 100644
index 0000000000..580675e118
--- /dev/null
+++ b/dom/webgpu/tests/cts/checkout/src/webgpu/api/validation/encoding/queries/begin_end.spec.ts
@@ -0,0 +1,162 @@
+export const description = `
+Validation for encoding begin/endable queries.
+
+TODO: pipeline statistics queries are removed from core; consider moving tests to another suite.
+TODO: tests for pipeline statistics queries:
+- balance: {
+    - begin 0, end 1
+    - begin 1, end 0
+    - begin 1, end 1
+    - begin 2, end 2
+    - }
+    - x= {
+        - render pass + pipeline statistics
+        - compute pass + pipeline statistics
+        - }
+`;
+
+import { makeTestGroup } from '../../../../../common/framework/test_group.js';
+import { ValidationTest } from '../../validation_test.js';
+
+import { beginRenderPassWithQuerySet, createQuerySetWithType } from './common.js';
+
+export const g = makeTestGroup(ValidationTest);
+
+g.test('occlusion_query,begin_end_balance')
+  .desc(
+    `
+Tests that begin/end occlusion queries mismatch on render pass:
+- begin n queries, then end m queries, for various n and m.
+  `
+  )
+  .paramsSubcasesOnly([
+    { begin: 0, end: 1 },
+    { begin: 1, end: 0 },
+    { begin: 1, end: 1 }, // control case
+    { begin: 1, end: 2 },
+    { begin: 2, end: 1 },
+  ] as const)
+  .fn(async t => {
+    const { begin, end } = t.params;
+
+    const occlusionQuerySet = createQuerySetWithType(t, 'occlusion', 2);
+
+    const encoder = t.createEncoder('render pass', { occlusionQuerySet });
+    for (let i = 0; i < begin; i++) {
+      encoder.encoder.beginOcclusionQuery(i);
+    }
+    for (let j = 0; j < end; j++) {
+      encoder.encoder.endOcclusionQuery();
+    }
+    encoder.validateFinishAndSubmit(begin === end, true);
+  });
+
+g.test('occlusion_query,begin_end_invalid_nesting')
+  .desc(
+    `
+Tests the invalid nesting of begin/end occlusion queries:
+- begin index 0, end, begin index 0, end (control case)
+- begin index 0, begin index 0, end, end
+- begin index 0, begin index 1, end, end
+  `
+  )
+  .paramsSubcasesOnly([
+    { calls: [0, 'end', 1, 'end'], _valid: true }, // control case
+    { calls: [0, 0, 'end', 'end'], _valid: false },
+    { calls: [0, 1, 'end', 'end'], _valid: false },
+  ] as const)
+  .fn(async t => {
+    const { calls, _valid } = t.params;
+
+    const occlusionQuerySet = createQuerySetWithType(t, 'occlusion', 2);
+
+    const encoder = t.createEncoder('render pass', { occlusionQuerySet });
+    for (const i of calls) {
+      if (i !== 'end') {
+        encoder.encoder.beginOcclusionQuery(i);
+      } else {
+        encoder.encoder.endOcclusionQuery();
+      }
+    }
+    encoder.validateFinishAndSubmit(_valid, true);
+  });
+
+g.test('occlusion_query,disjoint_queries_with_same_query_index')
+  .desc(
+    `
+Tests that two disjoint occlusion queries cannot be begun with same query index on same render pass:
+- begin index 0, end, begin index 0, end
+- call on {same (invalid), different (control case)} render pass
+  `
+  )
+  .paramsSubcasesOnly(u => u.combine('isOnSameRenderPass', [false, true]))
+  .fn(async t => {
+    const querySet = createQuerySetWithType(t, 'occlusion', 1);
+
+    const encoder = t.device.createCommandEncoder();
+    const pass = beginRenderPassWithQuerySet(t, encoder, querySet);
+    pass.beginOcclusionQuery(0);
+    pass.endOcclusionQuery();
+
+    if (t.params.isOnSameRenderPass) {
+      pass.beginOcclusionQuery(0);
+      pass.endOcclusionQuery();
+      pass.end();
+    } else {
+      pass.end();
+      const otherPass = beginRenderPassWithQuerySet(t, encoder, querySet);
+      otherPass.beginOcclusionQuery(0);
+      otherPass.endOcclusionQuery();
+      otherPass.end();
+    }
+
+    t.expectValidationError(() => {
+      encoder.finish();
+    }, t.params.isOnSameRenderPass);
+  });
+
+g.test('nesting')
+  .desc(
+    `
+Tests that whether it's allowed to nest various types of queries:
+- call {occlusion, pipeline-statistics, timestamp} query in same type or other type.
+  `
+  )
+  .paramsSubcasesOnly([
+    { begin: 'occlusion', nest: 'timestamp', end: 'occlusion', _valid: true },
+    { begin: 'occlusion', nest: 'occlusion', end: 'occlusion', _valid: false },
+    { begin: 'occlusion', nest: 'pipeline-statistics', end: 'occlusion', _valid: true },
+    {
+      begin: 'occlusion',
+      nest: 'pipeline-statistics',
+      end: 'pipeline-statistics',
+      _valid: true,
+    },
+    {
+      begin: 'pipeline-statistics',
+      nest: 'timestamp',
+      end: 'pipeline-statistics',
+      _valid: true,
+    },
+    {
+      begin: 'pipeline-statistics',
+      nest: 'pipeline-statistics',
+      end: 'pipeline-statistics',
+      _valid: false,
+    },
+    {
+      begin: 'pipeline-statistics',
+      nest: 'occlusion',
+      end: 'pipeline-statistics',
+      _valid: true,
+    },
+    { begin: 'pipeline-statistics', nest: 'occlusion', end: 'occlusion', _valid: true },
+    { begin: 'timestamp', nest: 'occlusion', end: 'occlusion', _valid: true },
+    {
+      begin: 'timestamp',
+      nest: 'pipeline-statistics',
+      end: 'pipeline-statistics',
+      _valid: true,
+    },
+  ] as const)
+  .unimplemented();