1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
<!--
Copyright (c) 2019 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
<script src="../../js/js-test-pre.js"></script>
<script src="../../js/webgl-test-utils.js"></script>
</head>
<body>
<div id="description"></div>
<div id="console"></div>
<script>
"use strict";
description("Test bufferData/bufferSubData with or without ArrayBuffer input");
debug('Regression test for <a href="https://bugs.webkit.org/show_bug.cgi?id=41884">https://bugs.webkit.org/show_bug.cgi?id=41884</a> : <code>Implement bufferData and bufferSubData with ArrayBuffer as input</code>');
var wtu = WebGLTestUtils;
var gl = wtu.create3DContext();
if (!gl) {
testFailed("WebGL context does not exist");
} else {
testPassed("WebGL context exists");
bufferDataTest();
bufferDataSizesTest();
bufferSubDataTest();
}
function bufferDataTest() {
debug("");
debug("Test bufferData without ArrayBuffer input");
var buf = gl.createBuffer();
shouldBeNonNull(buf);
gl.bufferData(gl.ARRAY_BUFFER, 4, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION, "no buffer bound");
gl.bindBuffer(gl.ARRAY_BUFFER, buf);
wtu.glErrorShouldBe(gl, gl.NO_ERROR);
gl.bufferData(gl.ARRAY_BUFFER, -4, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE,
"calling bufferData when buffer size is negative should generate INVALID_VALUE");
gl.bufferData(gl.ARRAY_BUFFER, null, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE,
"calling bufferData when BufferDataSource is null should generate INVALID_VALUE");
gl.bufferData(gl.ARRAY_BUFFER, undefined, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE,
"calling bufferData when BufferDataSource is undefined should generate INVALID_VALUE");
gl.bindBuffer(gl.ARRAY_BUFFER, null);
}
function bufferDataSizesTest() {
debug("");
debug("Test bufferData overloads");
// bufferData has an integer overload and an ArrayBuffer overload.
// Per the WebIDL spec, the overload resolution algorithm should resolve types as follows:
// - If the argument is null or undefined, pick the nullable type, which is ArrayBuffer.
// Per the WebGL spec, null should flag INVALID_VALUE.
// - If the argument is an ArrayBuffer, then pick the ArrayBuffer overload
// - Everything else should pick the numeric overload. This means things like objects, strings,
// floating point numbers, arrays of numbers and strings, etc should convert themselves to a number.
var bufferDataParams = [
{ parameter: 0, expectedBufferSize: 0 },
{ parameter: 4, expectedBufferSize: 4 },
{ parameter: 5.1, expectedBufferSize: 5 },
{ parameter: 5.8, expectedBufferSize: 5 },
{ parameter: 5.5, expectedBufferSize: 5 },
{ parameter: "4", expectedBufferSize: 4 },
{ parameter: "5.1", expectedBufferSize: 5 },
{ parameter: "5.8", expectedBufferSize: 5 },
{ parameter: "5.5", expectedBufferSize: 5 },
{ parameter: "0", expectedBufferSize: 0 },
{ parameter: [42, 64], expectedBufferSize: 0 },
{ parameter: [42], expectedBufferSize: 42 },
{ parameter: ["42"], expectedBufferSize: 42 },
{ parameter: ["42", "64"], expectedBufferSize: 0 },
{ parameter: new ArrayBuffer(0), expectedBufferSize: 0 },
{ parameter: new ArrayBuffer(4), expectedBufferSize: 4 },
{ parameter: new Uint8Array(new ArrayBuffer(5)), expectedBufferSize: 5 },
{ parameter: new DataView(new ArrayBuffer(7)), expectedBufferSize: 7 },
{ parameter: "WebGL Rocks!", expectedBufferSize: 0 },
{ parameter: { mystring: "WebGL Rocks!" }, expectedBufferSize: 0 },
];
if (window.SharedArrayBuffer) {
bufferDataParams.push(
{ parameter: new SharedArrayBuffer(3), expectedBufferSize: 3 },
{ parameter: new Uint8Array(new SharedArrayBuffer(6)), expectedBufferSize: 6 },
{ parameter: new DataView(new SharedArrayBuffer(8)), expectedBufferSize: 8 }
);
}
bufferDataParams.forEach(function (bufferDataParam) {
var buffer = gl.createBuffer();
gl.bindBuffer(gl.ARRAY_BUFFER, buffer);
gl.bufferData(gl.ARRAY_BUFFER, bufferDataParam.parameter, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "Passing " + bufferDataParam.parameter + " to bufferData");
shouldEvaluateTo("gl.getBufferParameter(gl.ARRAY_BUFFER, gl.BUFFER_SIZE)", bufferDataParam.expectedBufferSize);
});
gl.bindBuffer(gl.ARRAY_BUFFER, null);
}
function bufferSubDataTest() {
debug("");
debug("Test bufferSubData");
var buf = gl.createBuffer();
gl.bindBuffer(gl.ARRAY_BUFFER, buf);
gl.bufferSubData(gl.ARRAY_BUFFER, 0, new ArrayBuffer(1));
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE, "Calling bufferSubData before bufferData should fail");
gl.bufferData(gl.ARRAY_BUFFER, 128, gl.STATIC_DRAW);
wtu.glErrorShouldBe(gl, gl.NO_ERROR);
var array = new ArrayBuffer(64);
gl.bufferSubData(gl.ARRAY_BUFFER, -10, array);
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE,
"calling bufferSubData with ArrayBuffer when offset is negative should INVALID_VALUE");
gl.bufferSubData(gl.ARRAY_BUFFER, 65, array);
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE, "buffer overflow");
gl.bufferSubData(gl.ARRAY_BUFFER, -10, new Float32Array(8));
wtu.glErrorShouldBe(gl, gl.INVALID_VALUE,
"calling bufferSubData with ArrayBufferView when offset is negative should generate INVALID_VALUE");
gl.bufferSubData(gl.ARRAY_BUFFER, 10, array);
wtu.glErrorShouldBe(gl, gl.NO_ERROR,
"calling bufferSubData with ArrayBuffer should succeed");
gl.bufferSubData(gl.ARRAY_BUFFER, 10, new Float32Array(0));
wtu.glErrorShouldBe(gl, gl.NO_ERROR,
"calling bufferSubData with zero-sized ArrayBufferView should succeed");
// Arguments that are not ArrayBuffers, null or undefined should throw a TypeError exception
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 0, 42);");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 0, 5.5);");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 0, \"5.5\");");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 0, [4]);");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 0, { mynumber: 42});");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 10, null)");
shouldThrow("gl.bufferSubData(gl.ARRAY_BUFFER, 10, undefined)");
if (window.SharedArrayBuffer) {
const validDatas = [
'new SharedArrayBuffer(3)',
'new Uint8Array(new SharedArrayBuffer(3))',
'new DataView(new SharedArrayBuffer(3))',
];
for (const x of validDatas) {
shouldNotThrow(`gl.bufferSubData(gl.ARRAY_BUFFER, 0, ${x})`);
}
}
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "should generate no GL error");
// -
// Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1611837
gl.bindBuffer(gl.ARRAY_BUFFER, null);
gl.bufferSubData(gl.ARRAY_BUFFER, 0, new ArrayBuffer(0));
wtu.glErrorShouldBe(gl, gl.INVALID_OPERATION,
"Calling bufferSubData with empty ArrayBuffer and null WebGLBuffer should fail");
gl.bindBuffer(gl.ARRAY_BUFFER, gl.createBuffer());
gl.bufferSubData(gl.ARRAY_BUFFER, 0, new ArrayBuffer(0));
wtu.glErrorShouldBe(gl, 0,
"Calling bufferSubData with empty ArrayBuffer and non-null WebGLBuffer should succeed");
// -
gl.bindBuffer(gl.ARRAY_BUFFER, null);
}
var successfullyParsed = true;
</script>
<script src="../../js/js-test-post.js"></script>
</body>
</html>
|
