1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
export const description = `
createPipelineLayout validation tests.
TODO: review existing tests, write descriptions, and make sure tests are complete.
`;
import { makeTestGroup } from '../../../common/framework/test_group.js';
import { bufferBindingTypeInfo, kBufferBindingTypes } from '../../capability_info.js';
import { ValidationTest } from './validation_test.js';
function clone<T extends GPUBindGroupLayoutDescriptor>(descriptor: T): T {
return JSON.parse(JSON.stringify(descriptor));
}
export const g = makeTestGroup(ValidationTest);
g.test('number_of_dynamic_buffers_exceeds_the_maximum_value')
.desc(
`
Test that creating a pipeline layout fails with a validation error if the number of dynamic
buffers exceeds the maximum value in the pipeline layout.
- Test that creation of a pipeline using the maximum number of dynamic buffers added a dynamic
buffer fails.
TODO(#230): Update to enforce per-stage and per-pipeline-layout limits on BGLs as well.
`
)
.paramsSubcasesOnly(u =>
u //
.combine('visibility', [0, 2, 4, 6])
.combine('type', kBufferBindingTypes)
)
.fn(async t => {
const { type, visibility } = t.params;
const { maxDynamic } = bufferBindingTypeInfo({ type }).perPipelineLimitClass;
const maxDynamicBufferBindings: GPUBindGroupLayoutEntry[] = [];
for (let binding = 0; binding < maxDynamic; binding++) {
maxDynamicBufferBindings.push({
binding,
visibility,
buffer: { type, hasDynamicOffset: true },
});
}
const maxDynamicBufferBindGroupLayout = t.device.createBindGroupLayout({
entries: maxDynamicBufferBindings,
});
const goodDescriptor = {
entries: [{ binding: 0, visibility, buffer: { type, hasDynamicOffset: false } }],
};
const goodPipelineLayoutDescriptor = {
bindGroupLayouts: [
maxDynamicBufferBindGroupLayout,
t.device.createBindGroupLayout(goodDescriptor),
],
};
// Control case
t.device.createPipelineLayout(goodPipelineLayoutDescriptor);
// Check dynamic buffers exceed maximum in pipeline layout.
const badDescriptor = clone(goodDescriptor);
badDescriptor.entries[0].buffer.hasDynamicOffset = true;
const badPipelineLayoutDescriptor = {
bindGroupLayouts: [
maxDynamicBufferBindGroupLayout,
t.device.createBindGroupLayout(badDescriptor),
],
};
t.expectValidationError(() => {
t.device.createPipelineLayout(badPipelineLayoutDescriptor);
});
});
g.test('number_of_bind_group_layouts_exceeds_the_maximum_value')
.desc(
`
Test that creating a pipeline layout fails with a validation error if the number of bind group
layouts exceeds the maximum value in the pipeline layout.
- Test that creation of a pipeline using the maximum number of bind groups added a bind group
fails.
`
)
.fn(async t => {
const bindGroupLayoutDescriptor: GPUBindGroupLayoutDescriptor = {
entries: [],
};
// 4 is the maximum number of bind group layouts.
const maxBindGroupLayouts = [1, 2, 3, 4].map(() =>
t.device.createBindGroupLayout(bindGroupLayoutDescriptor)
);
const goodPipelineLayoutDescriptor = {
bindGroupLayouts: maxBindGroupLayouts,
};
// Control case
t.device.createPipelineLayout(goodPipelineLayoutDescriptor);
// Check bind group layouts exceed maximum in pipeline layout.
const badPipelineLayoutDescriptor = {
bindGroupLayouts: [
...maxBindGroupLayouts,
t.device.createBindGroupLayout(bindGroupLayoutDescriptor),
],
};
t.expectValidationError(() => {
t.device.createPipelineLayout(badPipelineLayoutDescriptor);
});
});
g.test('bind_group_layouts,device_mismatch')
.desc(
`
Tests createPipelineLayout cannot be called with bind group layouts created from another device
Test with two layouts to make sure all layouts can be validated:
- layout0 and layout1 from same device
- layout0 and layout1 from different device
`
)
.paramsSubcasesOnly([
{ layout0Mismatched: false, layout1Mismatched: false }, // control case
{ layout0Mismatched: true, layout1Mismatched: false },
{ layout0Mismatched: false, layout1Mismatched: true },
])
.beforeAllSubcases(t => {
t.selectMismatchedDeviceOrSkipTestCase(undefined);
})
.fn(async t => {
const { layout0Mismatched, layout1Mismatched } = t.params;
const mismatched = layout0Mismatched || layout1Mismatched;
const bglDescriptor: GPUBindGroupLayoutDescriptor = {
entries: [],
};
const layout0 = layout0Mismatched
? t.mismatchedDevice.createBindGroupLayout(bglDescriptor)
: t.device.createBindGroupLayout(bglDescriptor);
const layout1 = layout1Mismatched
? t.mismatchedDevice.createBindGroupLayout(bglDescriptor)
: t.device.createBindGroupLayout(bglDescriptor);
t.expectValidationError(() => {
t.device.createPipelineLayout({ bindGroupLayouts: [layout0, layout1] });
}, mismatched);
});
|
