1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
export const description = `
TODO:
- createCommandEncoder
- non-pass command, or beginPass, during {render, compute} pass
- {before (control case), after} finish()
- x= {finish(), ... all non-pass commands}
- {before (control case), after} end()
- x= {render, compute} pass
- x= {finish(), ... all relevant pass commands}
- x= {
- before endPass (control case)
- after endPass (no pass open)
- after endPass+beginPass (a new pass of the same type is open)
- }
- should make whole encoder invalid
- ?
`;
import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { objectEquals } from '../../../../common/util/util.js';
import { ValidationTest } from '../validation_test.js';
class F extends ValidationTest {
beginRenderPass(commandEncoder: GPUCommandEncoder, view: GPUTextureView): GPURenderPassEncoder {
return commandEncoder.beginRenderPass({
colorAttachments: [
{
view,
clearValue: { r: 1.0, g: 0.0, b: 0.0, a: 1.0 },
loadOp: 'clear',
storeOp: 'store',
},
],
});
}
createAttachmentTextureView(): GPUTextureView {
const texture = this.device.createTexture({
format: 'rgba8unorm',
size: { width: 1, height: 1, depthOrArrayLayers: 1 },
usage: GPUTextureUsage.RENDER_ATTACHMENT,
});
this.trackForCleanup(texture);
return texture.createView();
}
}
export const g = makeTestGroup(F);
g.test('pass_end_invalid_order')
.desc(
`
Test that beginning a {compute,render} pass before ending the previous {compute,render} pass
causes an error.
TODO: Update this test according to https://github.com/gpuweb/gpuweb/issues/2464
`
)
.params(u =>
u
.combine('pass0Type', ['compute', 'render'])
.combine('pass1Type', ['compute', 'render'])
.beginSubcases()
.combine('firstPassEnd', [true, false])
.combine('endPasses', [[], [0], [1], [0, 1], [1, 0]])
)
.fn(async t => {
const { pass0Type, pass1Type, firstPassEnd, endPasses } = t.params;
const view = t.createAttachmentTextureView();
const encoder = t.device.createCommandEncoder();
const firstPass =
pass0Type === 'compute' ? encoder.beginComputePass() : t.beginRenderPass(encoder, view);
if (firstPassEnd) firstPass.end();
// Begin a second pass before ending the previous pass.
const secondPass =
pass1Type === 'compute' ? encoder.beginComputePass() : t.beginRenderPass(encoder, view);
const passes = [firstPass, secondPass];
for (const index of endPasses) {
passes[index].end();
}
// If {endPasses} is '[1]' and {firstPass} ends, it's a control case.
const valid = firstPassEnd && objectEquals(endPasses, [1]);
t.expectValidationError(() => {
encoder.finish();
}, !valid);
});
g.test('call_after_successful_finish')
.desc(`Test that encoding command after a successful finish generates a validation error.`)
.params(u =>
u
.combine('callCmd', ['beginComputePass', 'beginRenderPass', 'insertDebugMarker'])
.beginSubcases()
.combine('prePassType', ['compute', 'render', 'no-op'])
.combine('IsEncoderFinished', [false, true])
)
.fn(async t => {
const { prePassType, IsEncoderFinished, callCmd } = t.params;
const view = t.createAttachmentTextureView();
const encoder = t.device.createCommandEncoder();
if (prePassType !== 'no-op') {
const pass =
prePassType === 'compute' ? encoder.beginComputePass() : t.beginRenderPass(encoder, view);
pass.end();
}
if (IsEncoderFinished) {
encoder.finish();
}
switch (callCmd) {
case 'beginComputePass':
{
let pass: GPUComputePassEncoder;
t.expectValidationError(() => {
pass = encoder.beginComputePass();
}, IsEncoderFinished);
t.expectValidationError(() => {
pass.end();
}, IsEncoderFinished);
}
break;
case 'beginRenderPass':
{
let pass: GPURenderPassEncoder;
t.expectValidationError(() => {
pass = t.beginRenderPass(encoder, view);
}, IsEncoderFinished);
t.expectValidationError(() => {
pass.end();
}, IsEncoderFinished);
}
break;
case 'insertDebugMarker':
t.expectValidationError(() => {
encoder.insertDebugMarker('');
}, IsEncoderFinished);
break;
}
if (!IsEncoderFinished) {
encoder.finish();
}
});
g.test('pass_end_none')
.desc(
`
Test that ending a {compute,render} pass without ending the passes generates a validation error.
`
)
.paramsSubcasesOnly(u => u.combine('passType', ['compute', 'render']).combine('endCount', [0, 1]))
.fn(async t => {
const { passType, endCount } = t.params;
const view = t.createAttachmentTextureView();
const encoder = t.device.createCommandEncoder();
const pass =
passType === 'compute' ? encoder.beginComputePass() : t.beginRenderPass(encoder, view);
for (let i = 0; i < endCount; ++i) {
pass.end();
}
t.expectValidationError(() => {
encoder.finish();
}, endCount === 0);
});
g.test('pass_end_twice')
.desc('Test that ending a {compute,render} pass twice generates a validation error.')
.paramsSubcasesOnly(u =>
u //
.combine('passType', ['compute', 'render'])
.combine('endTwice', [false, true])
)
.fn(async t => {
const { passType, endTwice } = t.params;
const view = t.createAttachmentTextureView();
const encoder = t.device.createCommandEncoder();
const pass =
passType === 'compute' ? encoder.beginComputePass() : t.beginRenderPass(encoder, view);
pass.end();
if (endTwice) {
t.expectValidationError(() => {
pass.end();
});
}
encoder.finish();
});
|
