1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
export const description = `
Tests execution of render bundles.
`;
import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { kDepthStencilFormats, kTextureFormatInfo } from '../../../capability_info.js';
import { ValidationTest } from '../validation_test.js';
export const g = makeTestGroup(ValidationTest);
g.test('empty_bundle_list')
.desc(
`
Test that it is valid to execute an empty list of render bundles
`
)
.fn(async t => {
const encoder = t.createEncoder('render pass');
encoder.encoder.executeBundles([]);
encoder.validateFinish(true);
});
g.test('device_mismatch')
.desc(
`
Tests executeBundles cannot be called with render bundles created from another device
Test with two bundles to make sure all bundles can be validated:
- bundle0 and bundle1 from same device
- bundle0 and bundle1 from different device
`
)
.paramsSubcasesOnly([
{ bundle0Mismatched: false, bundle1Mismatched: false }, // control case
{ bundle0Mismatched: true, bundle1Mismatched: false },
{ bundle0Mismatched: false, bundle1Mismatched: true },
])
.beforeAllSubcases(t => {
t.selectMismatchedDeviceOrSkipTestCase(undefined);
})
.fn(async t => {
const { bundle0Mismatched, bundle1Mismatched } = t.params;
const descriptor: GPURenderBundleEncoderDescriptor = {
colorFormats: ['rgba8unorm'],
};
const bundle0Device = bundle0Mismatched ? t.mismatchedDevice : t.device;
const bundle0 = bundle0Device.createRenderBundleEncoder(descriptor).finish();
const bundle1Device = bundle1Mismatched ? t.mismatchedDevice : t.device;
const bundle1 = bundle1Device.createRenderBundleEncoder(descriptor).finish();
const encoder = t.createEncoder('render pass');
encoder.encoder.executeBundles([bundle0, bundle1]);
encoder.validateFinish(!(bundle0Mismatched || bundle1Mismatched));
});
g.test('color_formats_mismatch')
.desc(
`
Tests executeBundles cannot be called with render bundles that do match the colorFormats of the
render pass. This includes:
- formats don't match
- formats match but are in a different order
- formats match but there is a different count
`
)
.params(u =>
u.combineWithParams([
{
bundleFormats: ['bgra8unorm', 'rg8unorm'] as const,
passFormats: ['bgra8unorm', 'rg8unorm'] as const,
_compatible: true,
}, // control case
{
bundleFormats: ['bgra8unorm', 'rg8unorm'] as const,
passFormats: ['bgra8unorm', 'bgra8unorm'] as const,
_compatible: false,
},
{
bundleFormats: ['bgra8unorm', 'rg8unorm'] as const,
passFormats: ['rg8unorm', 'bgra8unorm'] as const,
_compatible: false,
},
{
bundleFormats: ['bgra8unorm', 'rg8unorm', 'rgba8unorm'] as const,
passFormats: ['rg8unorm', 'bgra8unorm'] as const,
_compatible: false,
},
{
bundleFormats: ['bgra8unorm', 'rg8unorm'] as const,
passFormats: ['rg8unorm', 'bgra8unorm', 'rgba8unorm'] as const,
_compatible: false,
},
])
)
.fn(async t => {
const { bundleFormats, passFormats, _compatible } = t.params;
const bundleEncoder = t.device.createRenderBundleEncoder({
colorFormats: bundleFormats,
});
const bundle = bundleEncoder.finish();
const encoder = t.createEncoder('render pass', {
attachmentInfo: {
colorFormats: passFormats,
},
});
encoder.encoder.executeBundles([bundle]);
encoder.validateFinish(_compatible);
});
g.test('depth_stencil_formats_mismatch')
.desc(
`
Tests executeBundles cannot be called with render bundles that do match the depthStencil of the
render pass. This includes:
- formats don't match
- formats have matching depth or stencil aspects, but other aspects are missing
`
)
.params(u =>
u.combineWithParams([
{ bundleFormat: 'depth24plus', passFormat: 'depth24plus' }, // control case
{ bundleFormat: 'depth24plus', passFormat: 'depth16unorm' },
{ bundleFormat: 'depth24plus', passFormat: 'depth24plus-stencil8' },
{ bundleFormat: 'stencil8', passFormat: 'depth24plus-stencil8' },
] as const)
)
.beforeAllSubcases(t => {
const { bundleFormat, passFormat } = t.params;
t.selectDeviceForTextureFormatOrSkipTestCase([bundleFormat, passFormat]);
})
.fn(async t => {
const { bundleFormat, passFormat } = t.params;
const compatible = bundleFormat === passFormat;
const bundleEncoder = t.device.createRenderBundleEncoder({
colorFormats: [],
depthStencilFormat: bundleFormat,
});
const bundle = bundleEncoder.finish();
const encoder = t.createEncoder('render pass', {
attachmentInfo: {
colorFormats: [],
depthStencilFormat: passFormat,
},
});
encoder.encoder.executeBundles([bundle]);
encoder.validateFinish(compatible);
});
g.test('depth_stencil_readonly_mismatch')
.desc(
`
Tests executeBundles cannot be called with render bundles that do match the depthStencil
readonly state of the render pass.
`
)
.params(u =>
u
.combine('depthStencilFormat', kDepthStencilFormats)
.beginSubcases()
.combine('bundleDepthReadOnly', [false, true])
.combine('bundleStencilReadOnly', [false, true])
.combine('passDepthReadOnly', [false, true])
.combine('passStencilReadOnly', [false, true])
.filter(p => {
// For combined depth/stencil formats the depth and stencil read only state must match
// in order to create a valid render bundle or render pass.
const depthStencilInfo = kTextureFormatInfo[p.depthStencilFormat];
if (depthStencilInfo.depth && depthStencilInfo.stencil) {
return (
p.passDepthReadOnly === p.passStencilReadOnly &&
p.bundleDepthReadOnly === p.bundleStencilReadOnly
);
}
return true;
})
)
.beforeAllSubcases(t => {
t.selectDeviceForTextureFormatOrSkipTestCase(t.params.depthStencilFormat);
})
.fn(async t => {
const {
depthStencilFormat,
bundleDepthReadOnly,
bundleStencilReadOnly,
passDepthReadOnly,
passStencilReadOnly,
} = t.params;
const compatible =
(!passDepthReadOnly || bundleDepthReadOnly === passDepthReadOnly) &&
(!passStencilReadOnly || bundleStencilReadOnly === passStencilReadOnly);
const bundleEncoder = t.device.createRenderBundleEncoder({
colorFormats: [],
depthStencilFormat,
depthReadOnly: bundleDepthReadOnly,
stencilReadOnly: bundleStencilReadOnly,
});
const bundle = bundleEncoder.finish();
const encoder = t.createEncoder('render pass', {
attachmentInfo: {
colorFormats: [],
depthStencilFormat,
depthReadOnly: passDepthReadOnly,
stencilReadOnly: passStencilReadOnly,
},
});
encoder.encoder.executeBundles([bundle]);
encoder.validateFinish(compatible);
});
g.test('sample_count_mismatch')
.desc(
`
Tests executeBundles cannot be called with render bundles that do match the sampleCount of the
render pass.
`
)
.params(u =>
u.combineWithParams([
{ bundleSamples: 1, passSamples: 1 }, // control case
{ bundleSamples: 4, passSamples: 4 }, // control case
{ bundleFormat: 4, passFormat: 1 },
{ bundleFormat: 1, passFormat: 4 },
])
)
.fn(async t => {
const { bundleSamples, passSamples } = t.params;
const compatible = bundleSamples === passSamples;
const bundleEncoder = t.device.createRenderBundleEncoder({
colorFormats: ['bgra8unorm'],
sampleCount: bundleSamples,
});
const bundle = bundleEncoder.finish();
const encoder = t.createEncoder('render pass', {
attachmentInfo: {
colorFormats: ['bgra8unorm'],
sampleCount: passSamples,
},
});
encoder.encoder.executeBundles([bundle]);
encoder.validateFinish(compatible);
});
|
