1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
|
export const description = `
Tests writeBuffer validation.
Note: buffer map state is tested in ./buffer_mapped.spec.ts.
`;
import { makeTestGroup } from '../../../../common/framework/test_group.js';
import {
kTypedArrayBufferViewConstructors,
TypedArrayBufferView,
TypedArrayBufferViewConstructor,
} from '../../../../common/util/util.js';
import { Float16Array } from '../../../../external/petamoriken/float16/float16.js';
import { GPUConst } from '../../../constants.js';
import { kResourceStates } from '../../../gpu_test.js';
import { ValidationTest } from '../validation_test.js';
export const g = makeTestGroup(ValidationTest);
g.test('buffer_state')
.desc(
`
Test that the buffer used for GPUQueue.writeBuffer() must be valid. Tests calling writeBuffer
with {valid, invalid, destroyed} buffer.
`
)
.params(u => u.combine('bufferState', kResourceStates))
.fn(async t => {
const { bufferState } = t.params;
const buffer = t.createBufferWithState(bufferState, {
size: 16,
usage: GPUBufferUsage.COPY_DST,
});
const data = new Uint8Array(16);
const _valid = bufferState === 'valid';
t.expectValidationError(() => {
t.device.queue.writeBuffer(buffer, 0, data, 0, data.length);
}, !_valid);
});
g.test('ranges')
.desc(
`
Tests that the data ranges given to GPUQueue.writeBuffer() are properly validated. Tests calling
writeBuffer with both TypedArrays and ArrayBuffers and checks that the data offset and size is
interpreted correctly for both.
- When passing a TypedArray the data offset and size is given in elements.
- When passing an ArrayBuffer the data offset and size is given in bytes.
Also verifies that the specified data range:
- Describes a valid range of the destination buffer and source buffer.
- Fits fully within the destination buffer.
- Has a byte size which is a multiple of 4.
`
)
.fn(async t => {
const queue = t.device.queue;
function runTest(arrayType: TypedArrayBufferViewConstructor, testBuffer: boolean) {
const elementSize = arrayType.BYTES_PER_ELEMENT;
const bufferSize = 16 * elementSize;
const buffer = t.device.createBuffer({
size: bufferSize,
usage: GPUBufferUsage.COPY_DST,
});
const arraySm: TypedArrayBufferView | ArrayBuffer = testBuffer
? new arrayType(8).buffer
: new arrayType(8);
const arrayMd: TypedArrayBufferView | ArrayBuffer = testBuffer
? new arrayType(16).buffer
: new arrayType(16);
const arrayLg: TypedArrayBufferView | ArrayBuffer = testBuffer
? new arrayType(32).buffer
: new arrayType(32);
if (elementSize < 4) {
const array15: TypedArrayBufferView | ArrayBuffer = testBuffer
? new arrayType(15).buffer
: new arrayType(15);
// Writing the full buffer that isn't 4-byte aligned.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, array15));
// Writing from an offset that causes source to be 4-byte aligned.
queue.writeBuffer(buffer, 0, array15, 3);
// Writing from an offset that causes the source to not be 4-byte aligned.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arrayMd, 3));
// Writing with a size that is not 4-byte aligned.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, 0, 7));
}
// Writing the full buffer without offsets.
queue.writeBuffer(buffer, 0, arraySm);
queue.writeBuffer(buffer, 0, arrayMd);
t.expectValidationError(() => queue.writeBuffer(buffer, 0, arrayLg));
// Writing the full buffer with a 4-byte aligned offset.
queue.writeBuffer(buffer, 8, arraySm);
t.expectValidationError(() => queue.writeBuffer(buffer, 8, arrayMd));
// Writing the full buffer with a unaligned offset.
t.expectValidationError(() => queue.writeBuffer(buffer, 3, arraySm));
// Writing remainder of buffer from offset.
queue.writeBuffer(buffer, 0, arraySm, 4);
queue.writeBuffer(buffer, 0, arrayMd, 4);
t.expectValidationError(() => queue.writeBuffer(buffer, 0, arrayLg, 4));
// Writing a larger buffer from an offset that allows it to fit in the destination.
queue.writeBuffer(buffer, 0, arrayLg, 16);
// Writing with both an offset and size.
queue.writeBuffer(buffer, 0, arraySm, 4, 4);
// Writing with a size that extends past the source buffer length.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, 0, 16));
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, 4, 8));
// Writing with a size that is 4-byte aligned but an offset that is not.
queue.writeBuffer(buffer, 0, arraySm, 3, 4);
// Writing zero bytes at the end of the buffer.
queue.writeBuffer(buffer, bufferSize, arraySm, 0, 0);
// Writing with a buffer offset that is out of range of buffer size.
t.expectValidationError(() => queue.writeBuffer(buffer, bufferSize + 4, arraySm, 0, 0));
// Writing zero bytes from the end of the data.
queue.writeBuffer(buffer, 0, arraySm, 8, 0);
// Writing with a data offset that is out of range of data size.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, 9, 0));
// Writing with a data offset that is out of range of data size with implicit copy size.
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, 9, undefined));
// A data offset of undefined should be treated as 0.
queue.writeBuffer(buffer, 0, arraySm, undefined, 8);
t.shouldThrow('OperationError', () => queue.writeBuffer(buffer, 0, arraySm, undefined, 12));
}
runTest(Uint8Array, true);
for (const arrayType of kTypedArrayBufferViewConstructors) {
if (arrayType === Float16Array) {
// Skip Float16Array since it is supplied by an external module, so there isn't an overload for it.
continue;
}
runTest(arrayType, false);
}
});
g.test('usages')
.desc(
`
Tests calling writeBuffer with the buffer missed COPY_DST usage.
- buffer {with, without} COPY DST usage
`
)
.paramsSubcasesOnly([
{ usage: GPUConst.BufferUsage.COPY_DST, _valid: true }, // control case
{ usage: GPUConst.BufferUsage.STORAGE, _valid: false }, // without COPY_DST usage
{ usage: GPUConst.BufferUsage.STORAGE | GPUConst.BufferUsage.COPY_SRC, _valid: false }, // with other usage
{ usage: GPUConst.BufferUsage.STORAGE | GPUConst.BufferUsage.COPY_DST, _valid: true }, // with COPY_DST usage
])
.fn(async t => {
const { usage, _valid } = t.params;
const buffer = t.device.createBuffer({ size: 16, usage });
const data = new Uint8Array(16);
t.expectValidationError(() => {
t.device.queue.writeBuffer(buffer, 0, data, 0, data.length);
}, !_valid);
});
g.test('buffer,device_mismatch')
.desc('Tests writeBuffer cannot be called with a buffer created from another device.')
.paramsSubcasesOnly(u => u.combine('mismatched', [true, false]))
.beforeAllSubcases(t => {
t.selectMismatchedDeviceOrSkipTestCase(undefined);
})
.fn(async t => {
const { mismatched } = t.params;
const sourceDevice = mismatched ? t.mismatchedDevice : t.device;
const buffer = sourceDevice.createBuffer({
size: 16,
usage: GPUBufferUsage.COPY_DST,
});
t.trackForCleanup(buffer);
const data = new Uint8Array(16);
t.expectValidationError(() => {
t.device.queue.writeBuffer(buffer, 0, data, 0, data.length);
}, mismatched);
});
|
