1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
|
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "FilePreferences.h"
#include "mozilla/Atomics.h"
#include "mozilla/ClearOnShutdown.h"
#include "mozilla/Preferences.h"
#include "mozilla/StaticMutex.h"
#include "mozilla/StaticPtr.h"
#include "mozilla/TextUtils.h"
#include "mozilla/Tokenizer.h"
#include "nsAppDirectoryServiceDefs.h"
#include "nsDirectoryServiceDefs.h"
#include "nsDirectoryServiceUtils.h"
#include "nsString.h"
namespace mozilla {
namespace FilePreferences {
static StaticMutex sMutex;
static bool sBlockUNCPaths = false;
typedef nsTArray<nsString> WinPaths;
static WinPaths& PathAllowlist() MOZ_REQUIRES(sMutex) {
sMutex.AssertCurrentThreadOwns();
static WinPaths sPaths MOZ_GUARDED_BY(sMutex);
return sPaths;
}
#ifdef XP_WIN
const auto kDevicePathSpecifier = u"\\\\?\\"_ns;
typedef char16_t char_path_t;
#else
typedef char char_path_t;
#endif
// Initially false to make concurrent consumers acquire the lock and sync.
// The plain bool is synchronized with sMutex, the atomic one is for a quick
// check w/o the need to acquire the lock on the hot path.
static bool sForbiddenPathsEmpty = false;
static Atomic<bool, Relaxed> sForbiddenPathsEmptyQuickCheck{false};
typedef nsTArray<nsTString<char_path_t>> Paths;
static StaticAutoPtr<Paths> sForbiddenPaths;
static Paths& ForbiddenPaths() {
sMutex.AssertCurrentThreadOwns();
if (!sForbiddenPaths) {
sForbiddenPaths = new nsTArray<nsTString<char_path_t>>();
ClearOnShutdown(&sForbiddenPaths);
}
return *sForbiddenPaths;
}
static void AllowUNCDirectory(char const* directory) {
nsCOMPtr<nsIFile> file;
NS_GetSpecialDirectory(directory, getter_AddRefs(file));
if (!file) {
return;
}
nsString path;
if (NS_FAILED(file->GetTarget(path))) {
return;
}
// The allowlist makes sense only for UNC paths, because this code is used
// to block only UNC paths, hence, no need to add non-UNC directories here
// as those would never pass the check.
if (!StringBeginsWith(path, u"\\\\"_ns)) {
return;
}
StaticMutexAutoLock lock(sMutex);
if (!PathAllowlist().Contains(path)) {
PathAllowlist().AppendElement(path);
}
}
void InitPrefs() {
sBlockUNCPaths =
Preferences::GetBool("network.file.disable_unc_paths", false);
nsTAutoString<char_path_t> forbidden;
#ifdef XP_WIN
Preferences::GetString("network.file.path_blacklist", forbidden);
#else
Preferences::GetCString("network.file.path_blacklist", forbidden);
#endif
StaticMutexAutoLock lock(sMutex);
if (forbidden.IsEmpty()) {
sForbiddenPathsEmptyQuickCheck = (sForbiddenPathsEmpty = true);
return;
}
ForbiddenPaths().Clear();
TTokenizer<char_path_t> p(forbidden);
while (!p.CheckEOF()) {
nsTString<char_path_t> path;
Unused << p.ReadUntil(TTokenizer<char_path_t>::Token::Char(','), path);
path.Trim(" ");
if (!path.IsEmpty()) {
ForbiddenPaths().AppendElement(path);
}
Unused << p.CheckChar(',');
}
sForbiddenPathsEmptyQuickCheck =
(sForbiddenPathsEmpty = ForbiddenPaths().Length() == 0);
}
void InitDirectoriesAllowlist() {
// NS_GRE_DIR is the installation path where the binary resides.
AllowUNCDirectory(NS_GRE_DIR);
// NS_APP_USER_PROFILE_50_DIR and NS_APP_USER_PROFILE_LOCAL_50_DIR are the two
// parts of the profile we store permanent and local-specific data.
AllowUNCDirectory(NS_APP_USER_PROFILE_50_DIR);
AllowUNCDirectory(NS_APP_USER_PROFILE_LOCAL_50_DIR);
}
namespace { // anon
template <typename TChar>
class TNormalizer : public TTokenizer<TChar> {
typedef TTokenizer<TChar> base;
public:
typedef typename base::Token Token;
TNormalizer(const nsTSubstring<TChar>& aFilePath, const Token& aSeparator)
: TTokenizer<TChar>(aFilePath), mSeparator(aSeparator) {}
bool Get(nsTSubstring<TChar>& aNormalizedFilePath) {
aNormalizedFilePath.Truncate();
// Windows UNC paths begin with double separator (\\)
// Linux paths begin with just one separator (/)
// If we want to use the normalizer for regular windows paths this code
// will need to be updated.
#ifdef XP_WIN
if (base::Check(mSeparator)) {
aNormalizedFilePath.Append(mSeparator.AsChar());
}
#endif
if (base::Check(mSeparator)) {
aNormalizedFilePath.Append(mSeparator.AsChar());
}
while (base::HasInput()) {
if (!ConsumeName()) {
return false;
}
}
for (auto const& name : mStack) {
aNormalizedFilePath.Append(name);
}
return true;
}
private:
bool ConsumeName() {
if (base::CheckEOF()) {
return true;
}
if (CheckCurrentDir()) {
return true;
}
if (CheckParentDir()) {
if (!mStack.Length()) {
// This means there are more \.. than valid names
return false;
}
mStack.RemoveLastElement();
return true;
}
nsTDependentSubstring<TChar> name;
if (base::ReadUntil(mSeparator, name, base::INCLUDE_LAST) &&
name.Length() == 1) {
// this means an empty name (a lone slash), which is illegal
return false;
}
mStack.AppendElement(name);
return true;
}
bool CheckParentDir() {
typename nsTString<TChar>::const_char_iterator cursor = base::mCursor;
if (base::CheckChar('.') && base::CheckChar('.') && CheckSeparator()) {
return true;
}
base::mCursor = cursor;
return false;
}
bool CheckCurrentDir() {
typename nsTString<TChar>::const_char_iterator cursor = base::mCursor;
if (base::CheckChar('.') && CheckSeparator()) {
return true;
}
base::mCursor = cursor;
return false;
}
bool CheckSeparator() { return base::Check(mSeparator) || base::CheckEOF(); }
Token const mSeparator;
nsTArray<nsTDependentSubstring<TChar>> mStack;
};
#ifdef XP_WIN
bool IsDOSDevicePathWithDrive(const nsAString& aFilePath) {
if (!StringBeginsWith(aFilePath, kDevicePathSpecifier)) {
return false;
}
const auto pathNoPrefix =
nsDependentSubstring(aFilePath, kDevicePathSpecifier.Length());
// After the device path specifier, the rest of file path can be:
// - starts with the volume or drive. e.g. \\?\C:\...
// - UNCs. e.g. \\?\UNC\Server\Share\Test\Foo.txt
// - device UNCs. e.g. \\?\server1\e:\utilities\\filecomparer\...
// The first case should not be blocked by IsBlockedUNCPath.
if (!StartsWithDiskDesignatorAndBackslash(pathNoPrefix)) {
return false;
}
return true;
}
#endif
} // namespace
bool IsBlockedUNCPath(const nsAString& aFilePath) {
typedef TNormalizer<char16_t> Normalizer;
if (!sBlockUNCPaths) {
return false;
}
if (!StringBeginsWith(aFilePath, u"\\\\"_ns)) {
return false;
}
#ifdef XP_WIN
// ToDo: We don't need to check this once we can check if there is a valid
// server or host name that is prefaced by "\\".
// https://docs.microsoft.com/en-us/dotnet/standard/io/file-path-formats
if (IsDOSDevicePathWithDrive(aFilePath)) {
return false;
}
#endif
nsAutoString normalized;
if (!Normalizer(aFilePath, Normalizer::Token::Char('\\')).Get(normalized)) {
// Broken paths are considered invalid and thus inaccessible
return true;
}
StaticMutexAutoLock lock(sMutex);
for (const auto& allowedPrefix : PathAllowlist()) {
if (StringBeginsWith(normalized, allowedPrefix)) {
if (normalized.Length() == allowedPrefix.Length()) {
return false;
}
if (normalized[allowedPrefix.Length()] == L'\\') {
return false;
}
// When we are here, the path has a form "\\path\prefixevil"
// while we have an allowed prefix of "\\path\prefix".
// Note that we don't want to add a slash to the end of a prefix
// so that opening the directory (no slash at the end) still works.
break;
}
}
return true;
}
#ifdef XP_WIN
const char kPathSeparator = '\\';
#else
const char kPathSeparator = '/';
#endif
bool IsAllowedPath(const nsTSubstring<char_path_t>& aFilePath) {
typedef TNormalizer<char_path_t> Normalizer;
// An atomic quick check out of the lock, because this is mostly `true`.
if (sForbiddenPathsEmptyQuickCheck) {
return true;
}
StaticMutexAutoLock lock(sMutex);
if (sForbiddenPathsEmpty) {
return true;
}
// If sForbidden has been cleared at shutdown, we must avoid calling
// ForbiddenPaths() again, as that will recreate the array and we will leak.
if (!sForbiddenPaths) {
return true;
}
nsTAutoString<char_path_t> normalized;
if (!Normalizer(aFilePath, Normalizer::Token::Char(kPathSeparator))
.Get(normalized)) {
// Broken paths are considered invalid and thus inaccessible
return false;
}
for (const auto& prefix : ForbiddenPaths()) {
if (StringBeginsWith(normalized, prefix)) {
if (normalized.Length() > prefix.Length() &&
normalized[prefix.Length()] != kPathSeparator) {
continue;
}
return false;
}
}
return true;
}
#ifdef XP_WIN
bool StartsWithDiskDesignatorAndBackslash(const nsAString& aAbsolutePath) {
// aAbsolutePath can only be (in regular expression):
// UNC path: ^\\\\.*
// A single backslash: ^\\.*
// A disk designator with a backslash: ^[A-Za-z]:\\.*
return aAbsolutePath.Length() >= 3 && IsAsciiAlpha(aAbsolutePath.CharAt(0)) &&
aAbsolutePath.CharAt(1) == L':' &&
aAbsolutePath.CharAt(2) == kPathSeparator;
}
#endif
void testing::SetBlockUNCPaths(bool aBlock) { sBlockUNCPaths = aBlock; }
void testing::AddDirectoryToAllowlist(nsAString const& aPath) {
StaticMutexAutoLock lock(sMutex);
PathAllowlist().AppendElement(aPath);
}
bool testing::NormalizePath(nsAString const& aPath, nsAString& aNormalized) {
typedef TNormalizer<char16_t> Normalizer;
Normalizer normalizer(aPath, Normalizer::Token::Char('\\'));
return normalizer.Get(aNormalized);
}
} // namespace FilePreferences
} // namespace mozilla
|