1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
|
"use strict";
const { ExperimentAPI } = ChromeUtils.import(
"resource://nimbus/ExperimentAPI.jsm"
);
const { ExperimentFakes } = ChromeUtils.import(
"resource://testing-common/NimbusTestUtils.jsm"
);
const { TestUtils } = ChromeUtils.importESModule(
"resource://testing-common/TestUtils.sys.mjs"
);
const COLLECTION_ID_PREF = "messaging-system.rsexperimentloader.collection_id";
/**
* #getExperiment
*/
add_task(async function test_getExperiment_fromChild_slug() {
const sandbox = sinon.createSandbox();
const manager = ExperimentFakes.manager();
const expected = ExperimentFakes.experiment("foo");
await manager.onStartup();
sandbox.stub(ExperimentAPI, "_store").get(() => ExperimentFakes.childStore());
await manager.store.addEnrollment(expected);
// Wait to sync to child
await TestUtils.waitForCondition(
() => ExperimentAPI.getExperiment({ slug: "foo" }),
"Wait for child to sync"
);
Assert.equal(
ExperimentAPI.getExperiment({ slug: "foo" }).slug,
expected.slug,
"should return an experiment by slug"
);
Assert.deepEqual(
ExperimentAPI.getExperiment({ slug: "foo" }).branch,
expected.branch,
"should return the right branch by slug"
);
sandbox.restore();
});
add_task(async function test_getExperiment_fromParent_slug() {
const sandbox = sinon.createSandbox();
const manager = ExperimentFakes.manager();
const expected = ExperimentFakes.experiment("foo");
await manager.onStartup();
sandbox.stub(ExperimentAPI, "_store").get(() => manager.store);
await ExperimentAPI.ready();
await manager.store.addEnrollment(expected);
Assert.equal(
ExperimentAPI.getExperiment({ slug: "foo" }).slug,
expected.slug,
"should return an experiment by slug"
);
sandbox.restore();
});
add_task(async function test_getExperimentMetaData() {
const sandbox = sinon.createSandbox();
const manager = ExperimentFakes.manager();
const expected = ExperimentFakes.experiment("foo");
let exposureStub = sandbox.stub(ExperimentAPI, "recordExposureEvent");
await manager.onStartup();
sandbox.stub(ExperimentAPI, "_store").get(() => manager.store);
await ExperimentAPI.ready();
await manager.store.addEnrollment(expected);
let metadata = ExperimentAPI.getExperimentMetaData({ slug: expected.slug });
Assert.equal(
Object.keys(metadata.branch).length,
1,
"Should only expose one property"
);
Assert.equal(
metadata.branch.slug,
expected.branch.slug,
"Should have the slug prop"
);
Assert.ok(exposureStub.notCalled, "Not called for this method");
sandbox.restore();
});
add_task(async function test_getRolloutMetaData() {
const sandbox = sinon.createSandbox();
const manager = ExperimentFakes.manager();
const expected = ExperimentFakes.rollout("foo");
let exposureStub = sandbox.stub(ExperimentAPI, "recordExposureEvent");
await manager.onStartup();
sandbox.stub(ExperimentAPI, "_store").get(() => manager.store);
await ExperimentAPI.ready();
await manager.store.addEnrollment(expected);
let metadata = ExperimentAPI.getExperimentMetaData({ slug: expected.slug });
Assert.equal(
Object.keys(metadata.branch).length,
1,
"Should only expose one property"
);
Assert.equal(
metadata.branch.slug,
expected.branch.slug,
"Should have the slug prop"
);
Assert.ok(exposureStub.notCalled, "Not called for this method");
sandbox.restore();
});
add_task(function test_getExperimentMetaData_safe() {
const sandbox = sinon.createSandbox();
let exposureStub = sandbox.stub(ExperimentAPI, "recordExposureEvent");
sandbox.stub(ExperimentAPI._store, "get").throws();
sandbox.stub(ExperimentAPI._store, "getExperimentForFeature").throws();
try {
let metadata = ExperimentAPI.getExperimentMetaData({ slug: "foo" });
Assert.equal(metadata, null, "Should not throw");
} catch (e) {
Assert.ok(false, "Error should be caught in ExperimentAPI");
}
Assert.ok(ExperimentAPI._store.get.calledOnce, "Sanity check");
try {
let metadata = ExperimentAPI.getExperimentMetaData({ featureId: "foo" });
Assert.equal(metadata, null, "Should not throw");
} catch (e) {
Assert.ok(false, "Error should be caught in ExperimentAPI");
}
Assert.ok(
ExperimentAPI._store.getExperimentForFeature.calledOnce,
"Sanity check"
);
Assert.ok(exposureStub.notCalled, "Not called for this feature");
sandbox.restore();
});
add_task(async function test_getExperiment_feature() {
const sandbox = sinon.createSandbox();
const manager = ExperimentFakes.manager();
const expected = ExperimentFakes.experiment("foo", {
branch: {
slug: "treatment",
features: [{ featureId: "cfr", value: null }],
feature: {
featureId: "unused-feature-id-for-legacy-support",
enabled: false,
value: {},
},
},
});
await manager.onStartup();
sandbox.stub(ExperimentAPI, "_store").get(() => ExperimentFakes.childStore());
let exposureStub = sandbox.stub(ExperimentAPI, "recordExposureEvent");
await manager.store.addEnrollment(expected);
// Wait to sync to child
await TestUtils.waitForCondition(
() => ExperimentAPI.getExperiment({ featureId: "cfr" }),
"Wait for child to sync"
);
Assert.equal(
ExperimentAPI.getExperiment({ featureId: "cfr" }).slug,
expected.slug,
"should return an experiment by featureId"
);
Assert.deepEqual(
ExperimentAPI.getExperiment({ featureId: "cfr" }).branch,
expected.branch,
"should return the right branch by featureId"
);
Assert.ok(exposureStub.notCalled, "Not called by default");
sandbox.restore();
});
add_task(async function test_getExperiment_safe() {
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI._store, "getExperimentForFeature").throws();
try {
Assert.equal(
ExperimentAPI.getExperiment({ featureId: "foo" }),
null,
"It should not fail even when it throws."
);
} catch (e) {
Assert.ok(false, "Error should be caught by ExperimentAPI");
}
sandbox.restore();
});
add_task(async function test_getExperiment_featureAccess() {
const sandbox = sinon.createSandbox();
const expected = ExperimentFakes.experiment("foo", {
branch: {
slug: "treatment",
value: { title: "hi" },
features: [{ featureId: "cfr", value: { message: "content" } }],
},
});
const stub = sandbox
.stub(ExperimentAPI._store, "getExperimentForFeature")
.returns(expected);
let { branch } = ExperimentAPI.getExperiment({ featureId: "cfr" });
Assert.equal(branch.slug, "treatment");
let feature = branch.cfr;
Assert.ok(feature, "Should allow to access by featureId");
Assert.equal(feature.value.message, "content");
stub.restore();
});
add_task(async function test_getExperiment_featureAccess_backwardsCompat() {
const sandbox = sinon.createSandbox();
const expected = ExperimentFakes.experiment("foo", {
branch: {
slug: "treatment",
feature: { featureId: "cfr", value: { message: "content" } },
},
});
const stub = sandbox
.stub(ExperimentAPI._store, "getExperimentForFeature")
.returns(expected);
let { branch } = ExperimentAPI.getExperiment({ featureId: "cfr" });
Assert.equal(branch.slug, "treatment");
let feature = branch.cfr;
Assert.ok(feature, "Should allow to access by featureId");
Assert.equal(feature.value.message, "content");
stub.restore();
});
/**
* #getRecipe
*/
add_task(async function test_getRecipe() {
const sandbox = sinon.createSandbox();
const RECIPE = ExperimentFakes.recipe("foo");
const collectionName = Services.prefs.getStringPref(COLLECTION_ID_PREF);
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").resolves([RECIPE]);
const recipe = await ExperimentAPI.getRecipe("foo");
Assert.deepEqual(
recipe,
RECIPE,
"should return an experiment recipe if found"
);
Assert.equal(
ExperimentAPI._remoteSettingsClient.collectionName,
collectionName,
"Loaded the expected collection"
);
sandbox.restore();
});
add_task(async function test_getRecipe_Failure() {
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").throws();
const recipe = await ExperimentAPI.getRecipe("foo");
Assert.equal(recipe, undefined, "should return undefined if RS throws");
sandbox.restore();
});
/**
* #getAllBranches
*/
add_task(async function test_getAllBranches() {
const sandbox = sinon.createSandbox();
const RECIPE = ExperimentFakes.recipe("foo");
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").resolves([RECIPE]);
const branches = await ExperimentAPI.getAllBranches("foo");
Assert.deepEqual(
branches,
RECIPE.branches,
"should return all branches if found a recipe"
);
sandbox.restore();
});
// API used by Messaging System
add_task(async function test_getAllBranches_featureIdAccessor() {
const sandbox = sinon.createSandbox();
const RECIPE = ExperimentFakes.recipe("foo");
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").resolves([RECIPE]);
const branches = await ExperimentAPI.getAllBranches("foo");
Assert.deepEqual(
branches,
RECIPE.branches,
"should return all branches if found a recipe"
);
branches.forEach(branch => {
Assert.equal(
branch.testFeature.featureId,
"testFeature",
"Should use the experimentBranchAccessor proxy getter"
);
});
sandbox.restore();
});
// For schema version before 1.6.2 branch.feature was accessed
// instead of branch.features
add_task(async function test_getAllBranches_backwardsCompat() {
const sandbox = sinon.createSandbox();
const RECIPE = ExperimentFakes.recipe("foo");
delete RECIPE.branches[0].features;
delete RECIPE.branches[1].features;
let feature = {
featureId: "backwardsCompat",
value: {
enabled: true,
},
};
RECIPE.branches[0].feature = feature;
RECIPE.branches[1].feature = feature;
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").resolves([RECIPE]);
const branches = await ExperimentAPI.getAllBranches("foo");
Assert.deepEqual(
branches,
RECIPE.branches,
"should return all branches if found a recipe"
);
branches.forEach(branch => {
Assert.equal(
branch.backwardsCompat.featureId,
"backwardsCompat",
"Should use the experimentBranchAccessor proxy getter"
);
});
sandbox.restore();
});
add_task(async function test_getAllBranches_Failure() {
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI._remoteSettingsClient, "get").throws();
const branches = await ExperimentAPI.getAllBranches("foo");
Assert.equal(branches, undefined, "should return undefined if RS throws");
sandbox.restore();
});
/**
* #on
* #off
*/
add_task(async function test_addEnrollment_eventEmit_add() {
const sandbox = sinon.createSandbox();
const slugStub = sandbox.stub();
const featureStub = sandbox.stub();
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "purple", value: null }],
},
});
const store = ExperimentFakes.store();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
await store.init();
await ExperimentAPI.ready();
ExperimentAPI.on("update", { slug: "foo" }, slugStub);
ExperimentAPI.on("update", { featureId: "purple" }, featureStub);
await store.addEnrollment(experiment);
Assert.equal(
slugStub.callCount,
1,
"should call 'update' callback for slug when experiment is added"
);
Assert.equal(slugStub.firstCall.args[1].slug, experiment.slug);
Assert.equal(
featureStub.callCount,
1,
"should call 'update' callback for featureId when an experiment is added"
);
Assert.equal(featureStub.firstCall.args[1].slug, experiment.slug);
});
add_task(async function test_updateExperiment_eventEmit_add_and_update() {
const sandbox = sinon.createSandbox();
const slugStub = sandbox.stub();
const featureStub = sandbox.stub();
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "purple", value: null }],
},
});
const store = ExperimentFakes.store();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
await store.init();
await ExperimentAPI.ready();
await store.addEnrollment(experiment);
ExperimentAPI.on("update", { slug: "foo" }, slugStub);
ExperimentAPI.on("update", { featureId: "purple" }, featureStub);
store.updateExperiment(experiment.slug, experiment);
await TestUtils.waitForCondition(
() => slugStub.callCount == 2,
"Wait for `on` method to notify callback about the `add` event."
);
// Called twice, once when attaching the event listener (because there is an
// existing experiment with that name) and 2nd time for the update event
Assert.equal(slugStub.firstCall.args[1].slug, experiment.slug);
Assert.equal(featureStub.callCount, 2, "Called twice for feature");
Assert.equal(featureStub.firstCall.args[1].slug, experiment.slug);
});
add_task(async function test_updateExperiment_eventEmit_off() {
const sandbox = sinon.createSandbox();
const slugStub = sandbox.stub();
const featureStub = sandbox.stub();
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "purple", value: null }],
},
});
const store = ExperimentFakes.store();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
await store.init();
await ExperimentAPI.ready();
ExperimentAPI.on("update", { slug: "foo" }, slugStub);
ExperimentAPI.on("update", { featureId: "purple" }, featureStub);
await store.addEnrollment(experiment);
ExperimentAPI.off("update:foo", slugStub);
ExperimentAPI.off("update:purple", featureStub);
store.updateExperiment(experiment.slug, experiment);
Assert.equal(slugStub.callCount, 1, "Called only once before `off`");
Assert.equal(featureStub.callCount, 1, "Called only once before `off`");
});
add_task(async function test_getActiveBranch() {
const sandbox = sinon.createSandbox();
const store = ExperimentFakes.store();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "green", value: null }],
},
});
await store.init();
await store.addEnrollment(experiment);
Assert.deepEqual(
ExperimentAPI.getActiveBranch({ featureId: "green" }),
experiment.branch,
"Should return feature of active experiment"
);
sandbox.restore();
});
add_task(async function test_getActiveBranch_safe() {
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI._store, "getAllActive").throws();
try {
Assert.equal(
ExperimentAPI.getActiveBranch({ featureId: "green" }),
null,
"Should not throw"
);
} catch (e) {
Assert.ok(false, "Should catch error in ExperimentAPI");
}
sandbox.restore();
});
add_task(async function test_getActiveBranch_storeFailure() {
const store = ExperimentFakes.store();
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "green" }],
},
});
await store.init();
await store.addEnrollment(experiment);
// Adding stub later because `addEnrollment` emits update events
const stub = sandbox.stub(store, "emit");
// Call getActiveBranch to trigger an activation event
sandbox.stub(store, "getAllActive").throws();
try {
ExperimentAPI.getActiveBranch({ featureId: "green" });
} catch (e) {
/* This is expected */
}
Assert.equal(stub.callCount, 0, "Not called if store somehow fails");
sandbox.restore();
});
add_task(async function test_getActiveBranch_noActivationEvent() {
const store = ExperimentFakes.store();
const sandbox = sinon.createSandbox();
sandbox.stub(ExperimentAPI, "_store").get(() => store);
const experiment = ExperimentFakes.experiment("foo", {
branch: {
slug: "variant",
features: [{ featureId: "green" }],
},
});
await store.init();
await store.addEnrollment(experiment);
// Adding stub later because `addEnrollment` emits update events
const stub = sandbox.stub(store, "emit");
// Call getActiveBranch to trigger an activation event
ExperimentAPI.getActiveBranch({ featureId: "green" });
Assert.equal(stub.callCount, 0, "Not called: sendExposureEvent is false");
sandbox.restore();
});
|