blob: 4168826aeb135fe7e99b314bb6a70c4bbba8642a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include "check.hxx"
#include "plugin.hxx"
namespace {
class CharRightShift:
public loplugin::FilteringPlugin<CharRightShift>
{
public:
explicit CharRightShift(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
void run() override
{ TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitBinaryOperator(BinaryOperator const * expr) {
if (expr->getOpcode() != BO_Shr) {
return true;
}
if (ignoreLocation(expr)) {
return true;
}
auto t = expr->getLHS()->IgnoreParenImpCasts()->getType();
if (!loplugin::TypeCheck(t).Char()) {
return true;
}
if (!expr->getRHS()->getType()->isBuiltinType()) {
//TODO: in which case the expression should be an
// CXXOperatorCallExpr instead of a BinaryOperator? but at least
// recent Clang trunk reports
//
// '(' >> orExpression
//
// (connectivity/source/commontools/RowFunctionParser.cxx, the RHS
// being of type boost::spirit::rule<ScannerT>) here
return true;
}
report(
DiagnosticsEngine::Warning,
("right shift of %0 is implementation-defined when 'char' is signed"
" and value is negative"),
expr->getLHS()->getExprLoc())
<< t << expr->getSourceRange();
return true;
}
};
loplugin::Plugin::Registration<CharRightShift> charrightshift("charrightshift");
}
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
