1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <swmodeltestbase.hxx>
#include <com/sun/star/view/XSelectionSupplier.hpp>
#include <comphelper/classids.hxx>
#include <tools/globname.hxx>
#include <svtools/embedhlp.hxx>
#include <editeng/frmdiritem.hxx>
#include <vcl/errinf.hxx>
#include <vcl/event.hxx>
#include <editeng/langitem.hxx>
#include <sfx2/viewfrm.hxx>
#include <sfx2/dispatch.hxx>
#include <vcl/scheduler.hxx>
#include <comphelper/propertyvalue.hxx>
#include <wrtsh.hxx>
#include <fmtanchr.hxx>
#include <frameformats.hxx>
#include <docsh.hxx>
#include <edtwin.hxx>
#include <view.hxx>
#include <ndtxt.hxx>
#include <swdtflvr.hxx>
#include <cmdid.h>
#include <unotxdoc.hxx>
#include <UndoManager.hxx>
constexpr OUStringLiteral DATA_DIRECTORY = u"/sw/qa/core/doc/data/";
/// Covers sw/source/core/doc/ fixes.
class SwCoreDocTest : public SwModelTestBase
{
};
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testMathInsertAnchorType)
{
// Given an empty document.
SwDoc* pDoc = createSwDoc();
// When inserting an a math object.
SwWrtShell* pShell = pDoc->GetDocShell()->GetWrtShell();
SvGlobalName aGlobalName(SO3_SM_CLASSID);
pShell->InsertObject(svt::EmbeddedObjectRef(), &aGlobalName);
// Then the anchor type should be as-char.
SwFrameFormats& rFormats = *pDoc->GetSpzFrameFormats();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(1), rFormats.size());
const SwFrameFormat& rFormat = *rFormats[0];
const SwFormatAnchor& rAnchor = rFormat.GetAnchor();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 1
// - Actual : 4
// i.e. the anchor type was at-char, not as-char.
CPPUNIT_ASSERT_EQUAL(RndStdIds::FLY_AS_CHAR, rAnchor.GetAnchorId());
ErrorRegistry::Reset();
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testTextboxTextRotateAngle)
{
// Check the writing direction of the only TextFrame in the document.
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "textbox-textrotateangle.odt");
SwFrameFormats& rFrameFormats = *pDoc->GetSpzFrameFormats();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), rFrameFormats.size());
CPPUNIT_ASSERT_EQUAL(o3tl::narrowing<sal_uInt16>(RES_DRAWFRMFMT), rFrameFormats[0]->Which());
CPPUNIT_ASSERT_EQUAL(o3tl::narrowing<sal_uInt16>(RES_FLYFRMFMT), rFrameFormats[1]->Which());
SvxFrameDirection eActual = rFrameFormats[1]->GetAttrSet().GetItem(RES_FRAMEDIR)->GetValue();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 5 (btlr)
// - Actual : 0 (lrtb)
// i.e. the writing direction was in the ODT file, but it was lost on import in the textbox
// case.
CPPUNIT_ASSERT_EQUAL(SvxFrameDirection::Vertical_LR_BT, eActual);
ErrorRegistry::Reset();
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testNumDownIndent)
{
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "num-down-indent.docx");
SwDocShell* pDocShell = pDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
pWrtShell->Down(/*bSelect=*/false);
SwEditWin& rEditWin = pDocShell->GetView()->GetEditWin();
KeyEvent aKeyEvent(0, KEY_TAB);
rEditWin.KeyInput(aKeyEvent);
SwTextNode* pTextNode = pWrtShell->GetCursor()->GetNode().GetTextNode();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: \tB
// - Actual : B
// i.e. pressing <tab> at the start of the paragraph did not change the layout.
CPPUNIT_ASSERT_EQUAL(OUString("\tB"), pTextNode->GetText());
ErrorRegistry::Reset();
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testLocaleIndependentTemplate)
{
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "locale-independent-template.odt");
SwDocShell* pDocShell = pDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
SfxItemSet aSet(pWrtShell->GetAttrPool(), svl::Items<RES_CHRATR_LANGUAGE, RES_CHRATR_LANGUAGE>);
pWrtShell->GetCurAttr(aSet);
const SvxLanguageItem* pItem = aSet.GetItem(RES_CHRATR_LANGUAGE);
CPPUNIT_ASSERT(pItem);
LanguageType eLang = pItem->GetValue();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 1033 (LANGUAGE_ENGLISH_US)
// - Actual : 1023 (LANGUAGE_DONTKNOW)
// i.e. the status bar and the format -> character dialog didn't fall back to the UI locale when
// an explicit language was not set for the document.
CPPUNIT_ASSERT_EQUAL(LANGUAGE_ENGLISH_US, eLang);
ErrorRegistry::Reset();
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testTextBoxZOrder)
{
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "textbox-zorder.docx");
SwFrameFormats& rFormats = *pDoc->GetSpzFrameFormats();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(3), rFormats.size());
const SwFrameFormat* pEllipse = rFormats[2];
const SdrObject* pEllipseShape = pEllipse->FindRealSdrObject();
// Make sure we test the right shape.
CPPUNIT_ASSERT_EQUAL(OUString("Shape3"), pEllipseShape->GetName());
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 2
// - Actual : 1
// i.e. the ellipse was under the frame of the shape-frame pair, not on top of it.
CPPUNIT_ASSERT_EQUAL(static_cast<sal_uInt32>(2), pEllipseShape->GetOrdNum());
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testTextBoxMakeFlyFrame)
{
// Given a document with an as-char textbox (as-char draw format + at-char fly format):
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "textbox-makeflyframe.docx");
// When cutting the textbox and pasting it to a new document:
SwView* pView = pDoc->GetDocShell()->GetView();
pView->GetViewFrame()->GetDispatcher()->Execute(FN_CNTNT_TO_NEXT_FRAME, SfxCallMode::SYNCHRON);
pView->StopShellTimer();
SwDocShell* pDocShell = pDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
rtl::Reference<SwTransferable> pTransfer = new SwTransferable(*pWrtShell);
pTransfer->Cut();
TransferableDataHelper aHelper(pTransfer);
uno::Reference<lang::XComponent> xDoc2
= loadFromDesktop("private:factory/swriter", "com.sun.star.text.TextDocument", {});
SwXTextDocument* pTextDoc2 = dynamic_cast<SwXTextDocument*>(xDoc2.get());
SwDocShell* pDocShell2 = pTextDoc2->GetDocShell();
SwWrtShell* pWrtShell2 = pDocShell2->GetWrtShell();
SwTransferable::Paste(*pWrtShell2, aHelper);
// Then make sure its fly frame is created.
mxComponent->dispose();
mxComponent = xDoc2;
xmlDocUniquePtr pLayout = parseLayoutDump();
// Without the accompanying fix in place, this test would have failed, because the first text
// frame in the body frame had an SwAnchoredDrawObject anchored to it, but not a fly frame, so
// a blank square was painted, not the image.
assertXPath(pLayout, "/root/page/body/txt/anchored/fly", 1);
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testIMEGrouping)
{
// TODO figure out why the ext text input in this test code reaches the wrong window on
// non-headless.
#if !defined MACOSX && !defined _WIN32
// Given an empty document:
SwDoc* pDoc = createSwDoc();
// Make sure no idle is in action, so the ExtTextInput events go to SwEditWin.
Scheduler::ProcessEventsToIdle();
// When pressing two keys via IME:
SwDocShell* pDocShell = pDoc->GetDocShell();
SwEditWin& rEditWin = pDocShell->GetView()->GetEditWin();
rEditWin.PostExtTextInputEvent(VclEventId::ExtTextInput, "a");
rEditWin.PostExtTextInputEvent(VclEventId::EndExtTextInput, "");
rEditWin.PostExtTextInputEvent(VclEventId::ExtTextInput, "b");
rEditWin.PostExtTextInputEvent(VclEventId::EndExtTextInput, "");
// Then make sure that gets grouped together to a single undo action:
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
SwTextNode* pTextNode = pWrtShell->GetCursor()->GetNode().GetTextNode();
CPPUNIT_ASSERT_EQUAL(OUString("ab"), pTextNode->GetText());
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 1
// - Actual : 2
// i.e. 2 subsequent IME events got their own undo actions.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(1), pDoc->GetUndoManager().GetUndoActionCount());
#endif
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testImageHyperlinkStyle)
{
// Given a document with an image with a hyperlink:
loadURL("private:factory/swriter", nullptr);
uno::Reference<lang::XMultiServiceFactory> xFactory(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XTextDocument> xDocument(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XText> xText = xDocument->getText();
uno::Reference<text::XTextCursor> xCursor = xText->createTextCursor();
uno::Reference<text::XTextContent> xImage(
xFactory->createInstance("com.sun.star.text.TextGraphicObject"), uno::UNO_QUERY);
xText->insertTextContent(xCursor, xImage, /*bAbsorb=*/false);
uno::Reference<beans::XPropertySet> xImageProps(xImage, uno::UNO_QUERY);
OUString aExpected = "http://www.example.com";
xImageProps->setPropertyValue("HyperLinkURL", uno::Any(aExpected));
// When applying a frame style on it:
xImageProps->setPropertyValue("FrameStyleName", uno::Any(OUString("Frame")));
// Then make sure that the hyperlink is not lost:
auto aActual = getProperty<OUString>(xImageProps, "HyperLinkURL");
// Without the accompanying fix in place, this test would have failed with:
// - Expected: http://www.example.com
// - Actual :
// i.e. the link was lost, even if the frame style dialog doesn't allow specifying a link on
// frames.
CPPUNIT_ASSERT_EQUAL(aExpected, aActual);
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testContentControlDelete)
{
// Given a document with a content control:
SwDoc* pDoc = createSwDoc();
uno::Reference<lang::XMultiServiceFactory> xMSF(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XTextDocument> xTextDocument(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XText> xText = xTextDocument->getText();
uno::Reference<text::XTextCursor> xCursor = xText->createTextCursor();
xText->insertString(xCursor, "test", /*bAbsorb=*/false);
xCursor->gotoStart(/*bExpand=*/false);
xCursor->gotoEnd(/*bExpand=*/true);
uno::Reference<text::XTextContent> xContentControl(
xMSF->createInstance("com.sun.star.text.ContentControl"), uno::UNO_QUERY);
xText->insertTextContent(xCursor, xContentControl, /*bAbsorb=*/true);
// When deleting the dummy character at the end of the content control:
SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
pWrtShell->SttEndDoc(/*bStt=*/false);
pWrtShell->DelLeft();
// Then make sure that we only enter the content control, to be consistent with the start dummy
// character:
SwTextNode* pTextNode = pWrtShell->GetCursor()->GetMark()->nNode.GetNode().GetTextNode();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: ^Atest^A
// - Actual : ^Atest
// i.e. the end dummy character got deleted, but not the first one, which is inconsistent.
CPPUNIT_ASSERT_EQUAL(OUString("\x0001test\x0001"), pTextNode->GetText());
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testLinkedStyleDelete)
{
// Given a document with linked styles: myparastyle is linked to mycharstyle and vica versa:
createSwDoc();
uno::Reference<lang::XMultiServiceFactory> xFactory(mxComponent, uno::UNO_QUERY);
uno::Reference<beans::XPropertySet> xParaStyle(
xFactory->createInstance("com.sun.star.style.ParagraphStyle"), uno::UNO_QUERY);
uno::Reference<beans::XPropertySet> xCharStyle(
xFactory->createInstance("com.sun.star.style.CharacterStyle"), uno::UNO_QUERY);
uno::Reference<container::XNameContainer> xParaStyles(getStyles("ParagraphStyles"),
uno::UNO_QUERY);
xParaStyles->insertByName("myparastyle", uno::Any(xParaStyle));
uno::Reference<container::XNameContainer> xCharStyles(getStyles("CharacterStyles"),
uno::UNO_QUERY);
xCharStyles->insertByName("mycharstyle", uno::Any(xCharStyle));
xParaStyle->setPropertyValue("LinkStyle", uno::Any(OUString("mycharstyle")));
xCharStyle->setPropertyValue("LinkStyle", uno::Any(OUString("myparastyle")));
// When deleting the paragraph style (and only that):
xParaStyles->removeByName("myparastyle");
// Then make sure we don't crash on save:
uno::Reference<frame::XStorable> xStorable(mxComponent, uno::UNO_QUERY);
uno::Sequence<beans::PropertyValue> aArgs = {
comphelper::makePropertyValue("FilterName", OUString("writer8")),
};
xStorable->storeAsURL(maTempFile.GetURL(), aArgs);
}
namespace
{
/// This selection listener calls getAnchor() on selection change, which creates UNO cursors and is
/// invoked in the middle of a bookmark deletion.
struct SelectionChangeListener : public cppu::WeakImplHelper<view::XSelectionChangeListener>
{
uno::Reference<container::XNameAccess> m_xBookmarks;
std::vector<uno::Reference<text::XTextRange>> m_aAnchors;
public:
SelectionChangeListener(const uno::Reference<container::XNameAccess>& xBookmarks);
// view::XSelectionChangeListener
void SAL_CALL selectionChanged(const lang::EventObject& rEvent) override;
// lang::XEventListener
void SAL_CALL disposing(const lang::EventObject& rSource) override;
};
}
SelectionChangeListener::SelectionChangeListener(
const uno::Reference<container::XNameAccess>& xBookmarks)
: m_xBookmarks(xBookmarks)
{
}
void SelectionChangeListener::selectionChanged(const lang::EventObject& /*rEvent*/)
{
uno::Sequence<OUString> aElementNames = m_xBookmarks->getElementNames();
for (const auto& rName : aElementNames)
{
uno::Reference<text::XTextContent> xTextContent(m_xBookmarks->getByName(rName),
uno::UNO_QUERY);
m_aAnchors.push_back(xTextContent->getAnchor());
}
}
void SelectionChangeListener::disposing(const lang::EventObject& /*rSource*/) {}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testBookmarkDeleteListeners)
{
// Given a document with 2 bookmarks:
createSwDoc();
uno::Reference<text::XTextDocument> xTextDocument(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XText> xText = xTextDocument->getText();
uno::Reference<text::XTextCursor> xCursor = xText->createTextCursor();
{
xText->insertString(xCursor, "test", /*bAbsorb=*/false);
xCursor->gotoStart(/*bExpand=*/false);
xCursor->gotoEnd(/*bExpand=*/true);
uno::Reference<lang::XMultiServiceFactory> xFactory(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XTextContent> xBookmark(
xFactory->createInstance("com.sun.star.text.Bookmark"), uno::UNO_QUERY);
uno::Reference<container::XNamed> xBookmarkNamed(xBookmark, uno::UNO_QUERY);
xBookmarkNamed->setName("mybookmark");
xText->insertTextContent(xCursor, xBookmark, /*bAbsorb=*/true);
}
{
xCursor->gotoEnd(/*bExpand=*/false);
xText->insertString(xCursor, "test2", /*bAbsorb=*/false);
xCursor->goLeft(4, /*bExpand=*/true);
uno::Reference<lang::XMultiServiceFactory> xFactory(mxComponent, uno::UNO_QUERY);
uno::Reference<text::XTextContent> xBookmark(
xFactory->createInstance("com.sun.star.text.Bookmark"), uno::UNO_QUERY);
uno::Reference<container::XNamed> xBookmarkNamed(xBookmark, uno::UNO_QUERY);
xBookmarkNamed->setName("mybookmark2");
xText->insertTextContent(xCursor, xBookmark, /*bAbsorb=*/true);
}
uno::Reference<text::XBookmarksSupplier> xBookmarksSupplier(mxComponent, uno::UNO_QUERY);
uno::Reference<container::XNameAccess> xBookmarks = xBookmarksSupplier->getBookmarks();
// When registering a selection listener that creates uno marks:
uno::Reference<frame::XModel> xModel(mxComponent, uno::UNO_QUERY);
uno::Reference<view::XSelectionSupplier> xController(xModel->getCurrentController(),
uno::UNO_QUERY);
xController->addSelectionChangeListener(new SelectionChangeListener(xBookmarks));
// Then make sure that deleting a bookmark doesn't crash:
uno::Reference<lang::XComponent> xBookmark(xBookmarks->getByName("mybookmark2"),
uno::UNO_QUERY);
// Without the accompanying fix in place, this test would have crashed, an invalidated iterator
// was used with erase().
xBookmark->dispose();
}
CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testCopyBookmarks)
{
// Given a document with a bookmark in a header that is linked later:
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "copy-bookmarks.docx");
// When checking the # of non-copy bookmarks in the resulting doc model:
sal_Int32 nActual = 0;
for (auto it = pDoc->getIDocumentMarkAccess()->getBookmarksBegin();
it != pDoc->getIDocumentMarkAccess()->getBookmarksEnd(); ++it)
{
if ((*it)->GetName().indexOf("Copy") == -1)
{
++nActual;
}
}
// Then make sure we have a single non-copy bookmark, with no duplications:
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 1
// - Actual : 2
// i.e. the 2nd header had a duplicated bookmark without "Copy" in its name.
CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(1), nActual);
// Also, when checking the # of non-copy images in the resulting doc model:
nActual = 0;
SwFrameFormats& rFrameFormats = *pDoc->GetSpzFrameFormats();
for (size_t i = 0; i < rFrameFormats.size(); ++i)
{
if (rFrameFormats[i]->GetName().indexOf("Copy") == -1)
{
++nActual;
}
}
// Then make sure we have a single non-copy image, with no duplications:
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 1
// - Actual : 2
// i.e. the 2nd header had a duplicated image without "Copy" in its name.
CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(1), nActual);
}
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|