1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
|
// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <shlobj.h>
#include "sandbox/win/src/nt_internals.h"
#include "sandbox/win/src/registry_policy.h"
#include "sandbox/win/src/sandbox.h"
#include "sandbox/win/src/sandbox_factory.h"
#include "sandbox/win/src/sandbox_policy.h"
#include "sandbox/win/src/win_utils.h"
#include "sandbox/win/tests/common/controller.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
static const DWORD kAllowedRegFlags = KEY_QUERY_VALUE | KEY_ENUMERATE_SUB_KEYS |
KEY_NOTIFY | KEY_READ | GENERIC_READ |
GENERIC_EXECUTE | READ_CONTROL;
#define BINDNTDLL(name) \
name##Function name = reinterpret_cast<name##Function>( \
::GetProcAddress(::GetModuleHandle(L"ntdll.dll"), #name))
bool IsKeyOpenForRead(HKEY handle) {
BINDNTDLL(NtQueryObject);
OBJECT_BASIC_INFORMATION info = {0};
NTSTATUS status = NtQueryObject(handle, ObjectBasicInformation, &info,
sizeof(info), nullptr);
if (!NT_SUCCESS(status))
return false;
if ((info.GrantedAccess & (~kAllowedRegFlags)) != 0)
return false;
return true;
}
} // namespace
namespace sandbox {
SBOX_TESTS_COMMAND int Reg_OpenKey(int argc, wchar_t** argv) {
if (argc != 4)
return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
REGSAM desired_access = 0;
ULONG options = 0;
if (wcscmp(argv[1], L"read") == 0) {
desired_access = KEY_READ;
} else if (wcscmp(argv[1], L"write") == 0) {
desired_access = KEY_ALL_ACCESS;
} else if (wcscmp(argv[1], L"link") == 0) {
options = REG_OPTION_CREATE_LINK;
desired_access = KEY_ALL_ACCESS;
} else {
desired_access = MAXIMUM_ALLOWED;
}
HKEY root = GetReservedKeyFromName(argv[2]);
HKEY key;
LRESULT result = 0;
if (wcscmp(argv[0], L"create") == 0)
result = ::RegCreateKeyEx(root, argv[3], 0, nullptr, options,
desired_access, nullptr, &key, nullptr);
else
result = ::RegOpenKeyEx(root, argv[3], 0, desired_access, &key);
if (ERROR_SUCCESS == result) {
if (MAXIMUM_ALLOWED == desired_access) {
if (!IsKeyOpenForRead(key)) {
::RegCloseKey(key);
return SBOX_TEST_FAILED;
}
}
::RegCloseKey(key);
return SBOX_TEST_SUCCEEDED;
} else if (ERROR_ACCESS_DENIED == result) {
return SBOX_TEST_DENIED;
}
return SBOX_TEST_FAILED;
}
TEST(RegistryPolicyTest, TestKeyAnyAccess) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_ANY,
L"HKEY_LOCAL_MACHINE\\Software\\Microsoft"));
// Tests read access on key allowed for read-write.
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey create read HKEY_LOCAL_MACHINE software\\microsoft"));
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey open read HKEY_LOCAL_MACHINE software\\microsoft"));
if (::IsUserAnAdmin()) {
// Tests write access on key allowed for read-write.
EXPECT_EQ(SBOX_TEST_SUCCEEDED,
runner.RunTest(L"Reg_OpenKey create write HKEY_LOCAL_MACHINE "
L"software\\microsoft"));
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey open write HKEY_LOCAL_MACHINE software\\microsoft"));
}
// Tests subdirectory access on keys where we don't have subdirectory acess.
EXPECT_EQ(SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey create read "
L"HKEY_LOCAL_MACHINE software\\microsoft\\Windows"));
EXPECT_EQ(SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey open read "
L"HKEY_LOCAL_MACHINE software\\microsoft\\windows"));
// Tests to see if we can create keys where we dont have subdirectory access.
// This is denied.
EXPECT_EQ(SBOX_TEST_DENIED,
runner.RunTest(
L"Reg_OpenKey create write "
L"HKEY_LOCAL_MACHINE software\\Microsoft\\google_unit_tests"));
RegDeleteKey(HKEY_LOCAL_MACHINE, L"software\\Microsoft\\google_unit_tests");
// Tests if we need to handle differently the "\\" at the end.
// This is denied. We need to add both rules.
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(
L"Reg_OpenKey create read HKEY_LOCAL_MACHINE software\\microsoft\\"));
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(
L"Reg_OpenKey open read HKEY_LOCAL_MACHINE software\\microsoft\\"));
}
TEST(RegistryPolicyTest, TestKeyNoAccess) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE"));
// Tests read access where we don't have access at all.
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey create read HKEY_LOCAL_MACHINE software"));
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey open read HKEY_LOCAL_MACHINE software"));
}
TEST(RegistryPolicyTest, TestKeyReadOnlyAccess) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies\\*"));
// Tests subdirectory acess on keys where we have subdirectory acess.
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(L"Reg_OpenKey create read "
L"HKEY_LOCAL_MACHINE software\\Policies\\microsoft"));
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(L"Reg_OpenKey open read "
L"HKEY_LOCAL_MACHINE software\\Policies\\microsoft"));
// Tests to see if we can create keys where we have subdirectory access.
EXPECT_EQ(SBOX_TEST_DENIED,
runner.RunTest(
L"Reg_OpenKey create write "
L"HKEY_LOCAL_MACHINE software\\Policies\\google_unit_tests"));
RegDeleteKey(HKEY_LOCAL_MACHINE, L"software\\Policies\\google_unit_tests");
}
TEST(RegistryPolicyTest, TestKeyAllAccessSubDir) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_ANY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_ANY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies\\*"));
if (::IsUserAnAdmin()) {
// Tests to see if we can create keys where we have subdirectory access.
EXPECT_EQ(SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey create write "
L"HKEY_LOCAL_MACHINE software\\Policies\\google_unit_tests"));
RegDeleteKey(HKEY_LOCAL_MACHINE, L"software\\Policies\\google_unit_tests");
}
}
TEST(RegistryPolicyTest, TestKeyCreateLink) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_LOCAL_MACHINE"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_ANY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_ANY,
L"HKEY_LOCAL_MACHINE\\Software\\Policies\\*"));
// Tests to see if we can create a registry link key.
// NOTE: In theory here we should make sure to check for SBOX_TEST_DENIED
// instead of !SBOX_TEST_SUCCEEDED, but unfortunately the result is not
// access denied. Internally RegCreateKeyEx (At least on Vista 64) tries to
// create the link, and we return successfully access denied, then, it
// decides to try to break the path in multiple chunks, and create the links
// one by one. In this scenario, it tries to create "HKLM\Software" as a
// link key, which obviously fail with STATUS_OBJECT_NAME_COLLISION, and
// this is what is returned to the user.
EXPECT_NE(SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey create link "
L"HKEY_LOCAL_MACHINE software\\Policies\\google_unit_tests"));
// In case our code fails, and the call works, we need to delete the new
// link. There is no api for this, so we need to use the NT call.
HKEY key = nullptr;
LRESULT result = ::RegOpenKeyEx(HKEY_LOCAL_MACHINE,
L"software\\Policies\\google_unit_tests",
REG_OPTION_OPEN_LINK, MAXIMUM_ALLOWED, &key);
if (!result) {
HMODULE ntdll = GetModuleHandle(L"ntdll.dll");
NtDeleteKeyFunction NtDeleteKey = reinterpret_cast<NtDeleteKeyFunction>(
GetProcAddress(ntdll, "NtDeleteKey"));
NtDeleteKey(key);
}
}
TEST(RegistryPolicyTest, TestKeyReadOnlyHKCU) {
TestRunner runner;
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_CURRENT_USER"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_CURRENT_USER\\Software"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_USERS\\.default"));
EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_REGISTRY,
TargetPolicy::REG_ALLOW_READONLY,
L"HKEY_USERS\\.default\\software"));
// Tests read access where we only have read-only access.
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(L"Reg_OpenKey create read HKEY_CURRENT_USER software"));
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(L"Reg_OpenKey open read HKEY_CURRENT_USER software"));
// Tests write access where we only have read-only acess.
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey create write HKEY_CURRENT_USER software"));
EXPECT_EQ(
SBOX_TEST_DENIED,
runner.RunTest(L"Reg_OpenKey open write HKEY_CURRENT_USER software"));
// Tests maximum allowed access where we only have read-only access.
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey create maximum_allowed HKEY_CURRENT_USER software"));
EXPECT_EQ(
SBOX_TEST_SUCCEEDED,
runner.RunTest(
L"Reg_OpenKey open maximum_allowed HKEY_CURRENT_USER software"));
}
} // namespace sandbox
|
