Merging upstream version 23.7.0.

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

1 files changed, 12 insertions, 4 deletions

diff --git a/sqlglot/helper.py b/sqlglot/helper.py
index 0d4547f..0187c51 100644
--- a/sqlglot/helper.py
+++ b/sqlglot/helper.py
@@ -181,7 +181,7 @@ def apply_index_offset(
         annotate_types(expression)
     if t.cast(exp.DataType, expression.type).this in exp.DataType.INTEGER_TYPES:
         logger.warning("Applying array index offset (%s)", offset)
-        expression = simplify(exp.Add(this=expression, expression=exp.Literal.number(offset)))
+        expression = simplify(expression + offset)
         return [expression]
 
     return expressions
@@ -204,13 +204,13 @@ def while_changing(expression: Expression, func: t.Callable[[Expression], E]) ->
         The transformed expression.
     """
     while True:
-        for n, *_ in reversed(tuple(expression.walk())):
+        for n in reversed(tuple(expression.walk())):
             n._hash = hash(n)
 
         start = hash(expression)
         expression = func(expression)
 
-        for n, *_ in expression.walk():
+        for n in expression.walk():
             n._hash = None
         if start == hash(expression):
             break
@@ -317,8 +317,16 @@ def find_new_name(taken: t.Collection[str], base: str) -> str:
 
 
 def is_int(text: str) -> bool:
+    return is_type(text, int)
+
+
+def is_float(text: str) -> bool:
+    return is_type(text, float)
+
+
+def is_type(text: str, target_type: t.Type) -> bool:
     try:
-        int(text)
+        target_type(text)
         return True
     except ValueError:
         return False