summaryrefslogtreecommitdiffstats
path: root/sqlglot/optimizer/qualify_columns.py
diff options
context:
space:
mode:
authorDaniel Baumann <daniel.baumann@progress-linux.org>2022-11-05 18:41:12 +0000
committerDaniel Baumann <daniel.baumann@progress-linux.org>2022-11-05 18:41:12 +0000
commit7ff5bab54e3298dd89132706f6adee17f5164f6d (patch)
tree9b5896df787dbce648aa95d02c5c15ff34beb1c6 /sqlglot/optimizer/qualify_columns.py
parentReleasing debian version 9.0.3-1. (diff)
downloadsqlglot-7ff5bab54e3298dd89132706f6adee17f5164f6d.tar.xz
sqlglot-7ff5bab54e3298dd89132706f6adee17f5164f6d.zip
Merging upstream version 9.0.6.
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to 'sqlglot/optimizer/qualify_columns.py')
-rw-r--r--sqlglot/optimizer/qualify_columns.py21
1 files changed, 13 insertions, 8 deletions
diff --git a/sqlglot/optimizer/qualify_columns.py b/sqlglot/optimizer/qualify_columns.py
index 36ba028..ebee92a 100644
--- a/sqlglot/optimizer/qualify_columns.py
+++ b/sqlglot/optimizer/qualify_columns.py
@@ -211,21 +211,26 @@ def _qualify_columns(scope, resolver):
if column_table:
column.set("table", exp.to_identifier(column_table))
+ columns_missing_from_scope = []
# Determine whether each reference in the order by clause is to a column or an alias.
for ordered in scope.find_all(exp.Ordered):
for column in ordered.find_all(exp.Column):
- column_table = column.table
- column_name = column.name
+ if not column.table and column.parent is not ordered and column.name in resolver.all_columns:
+ columns_missing_from_scope.append(column)
- if column_table or column.parent is ordered or column_name not in resolver.all_columns:
- continue
+ # Determine whether each reference in the having clause is to a column or an alias.
+ for having in scope.find_all(exp.Having):
+ for column in having.find_all(exp.Column):
+ if not column.table and column.find_ancestor(exp.AggFunc) and column.name in resolver.all_columns:
+ columns_missing_from_scope.append(column)
- column_table = resolver.get_table(column_name)
+ for column in columns_missing_from_scope:
+ column_table = resolver.get_table(column.name)
- if column_table is None:
- raise OptimizeError(f"Ambiguous column: {column_name}")
+ if column_table is None:
+ raise OptimizeError(f"Ambiguous column: {column.name}")
- column.set("table", exp.to_identifier(column_table))
+ column.set("table", exp.to_identifier(column_table))
def _expand_stars(scope, resolver):